WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 19 months ago

#15734 closed enhancement (fixed)

Add soundcloud.com oEmbed support

Reported by: ericwahlforss Owned by: markjaquith
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch
Focuses: Cc:

Description

SoundCloud is the most popular site for audio/music sharing. It's to sound what Flickr is to photos and Youtube is to video. It has had oEmbed support for over a year now, would be great to support as many music bloggers are using WP+SoundCloud.

Attachments (2)

15734.patch (797 bytes) - added by ericwahlforss 3 years ago.
update oembed class to support soundcloud
add-oembed-providers.diff (968 bytes) - added by wonderboymusic 21 months ago.

Download all attachments as: .zip

Change History (11)

ericwahlforss3 years ago

update oembed class to support soundcloud

comment:1 westi3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to maybelater
  • Status changed from new to closed

This is best in a plugin for now

comment:2 wonderboymusic21 months ago

  • Resolution maybelater deleted
  • Status changed from closed to reopened

Add Soundcloud and Kickstarter - I seriously doubt Funny or Die is widely embedded and it is a default provider. Attached a new patch.

comment:3 SergeyBiryukov21 months ago

  • Milestone set to Awaiting Review

comment:4 scribu20 months ago

  • Milestone changed from Awaiting Review to 3.5

comment:5 nacin19 months ago

  • Owner set to markjaquith
  • Status changed from reopened to assigned

Asking Mark to make a determination for this.

comment:6 dwainm19 months ago

Could we add support for sound cloud short code as well : http://snd.sc/RuMhzl

comment:7 nacin19 months ago

Per an IRC dev chat, soundcloud.com is good to go if the oEmbed endpoint checks out.

comment:8 nacin19 months ago

soundcloud.com has a weird thing with their endpoint. They pass a width of 100% by default, which is against the spec (supposed to be pixels), but the moment you pass a maxwidth (which we always do), it uses that value instead. So we're good. Just a little quirk.

comment:9 nacin19 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In [22003]:

Add soundcloud and slideshare to the oEmbed providers list. props bradparbs, ericwahlforss, wonderboymusic. fixes #15734, #21635.

Note: See TracTickets for help on using tickets.