Opened 14 years ago
Closed 14 years ago
#15739 closed task (blessed) (fixed)
Expand/collapse in internal linking
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 3.1 | Priority: | normal |
Severity: | normal | Version: | 3.1 |
Component: | Administration | Keywords: | needs-testing |
Focuses: | Cc: |
Description
We should use our user settings API to have a save-state expand/collapse the internal linking part of the links dialog.
This will require a small arrow sprite and some light JS to our API.
Jane wanted this for 3.1, but I don't see it happening unless someone finds time this week.
Attachments (9)
Change History (37)
#3
@
14 years ago
Attaching my own patch as well, something I forgot to do (which I wrote for some JS practice). Has some minor todo for sliding, and also has no UI/images toggle, just a dummy link.
#4
@
14 years ago
Ignore my patch, they are completely different aspect...next time will read the tickets more carefully.
#8
@
14 years ago
Needs a little UI love around the expand/collapse before RC. Will discuss with UI group.
#9
@
14 years ago
- Owner set to JohnONolan
- Status changed from new to assigned
John will be doing a 4-arrow sprite.
#11
@
14 years ago
- Keywords needs-patch added; has-patch ui-feedback removed
- Owner nacin deleted
Can someone try whipping up some CSS around this?
#12
follow-up:
↓ 15
@
14 years ago
I want to change this string, "Link to Content on this Site", because it looks ridiculous with "C" and "S". The easy option is "Link to content on this site". Do we want to return the word "existing"? It was previously "link to existing site content" before we added the expand/collapse.
So, one of these:
- "Link to content on this site"
- "Link to existing content on this site"
- "Link to existing site content"
#14
follow-up:
↓ 16
@
14 years ago
@JohnONolan
Would be nice if you could change the sprite, so that the images are vertical oriented.
#15
in reply to:
↑ 12
@
14 years ago
Replying to nacin:
I want to change this string, "Link to Content on this Site", because it looks ridiculous with "C" and "S".
- Or link to existing content
#16
in reply to:
↑ 14
@
14 years ago
Replying to ocean90:
@JohnONolan
Would be nice if you could change the sprite, so that the images are vertical oriented.
Sure... just rotate the image 90 degrees in either direction ;)
#17
@
14 years ago
We're also dropping the colon in 'Enter the destination URL' for consistency.
The link around "Or link to existing content" should be dropped. It should still be clickable, but it should be the collapsed arrow inviting a click. I imagine it will be easier to drop the <a> and make the div (or a span the width of the text) clickable, rather than styling the <a> to match body text in terms of color and no underline.
#20
@
14 years ago
- Keywords has-patch added; needs-patch removed
In 15739.drop.link.patch
the link is dropped.
#22
@
14 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening due to stated browser issues and final testing.
#24
@
14 years ago
15739.fix.background-position.patch
will fix the arrow toggle for Firefox and Opera and has a small fix for long titles.
#26
@
14 years ago
- Keywords needs-testing added; has-patch removed
what's left: final browser testing down to IE6, and checking long title handling.
attached file has images which should be in wp-includes\js\tinymce\plugins\wplink\css