WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#15739 closed task (blessed) (fixed)

Expand/collapse in internal linking

Reported by: nacin Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords: needs-testing
Focuses: Cc:

Description

We should use our user settings API to have a save-state expand/collapse the internal linking part of the links dialog.

This will require a small arrow sprite and some light JS to our API.

Jane wanted this for 3.1, but I don't see it happening unless someone finds time this week.

Attachments (9)

internal-linking.zip (3.3 KB) - added by greuben 10 years ago.
attached file has images which should be in wp-includes\js\tinymce\plugins\wplink\css
internal-linking.diff (8.1 KB) - added by greuben 10 years ago.
15739.nacin.diff (3.6 KB) - added by nacin 10 years ago.
My incomplete version.
15739.diff (4.9 KB) - added by koopersmith 10 years ago.
ie-fixes.diff (1.4 KB) - added by koopersmith 10 years ago.
sprite.png (445 bytes) - added by JohnONolan 10 years ago.
Try this on for size and let me know how you get on, can tweak if req'd.
15739.drop.link.patch (3.2 KB) - added by ocean90 10 years ago.
toggle-arrow.png (3.2 KB) - added by ocean90 10 years ago.
Sprite, place it in wp-includes/js/tinymce/plugins/wplink/img
15739.fix.background-position.patch (1.2 KB) - added by ocean90 10 years ago.

Download all attachments as: .zip

Change History (37)

#1 @nacin
10 years ago

  • Type changed from defect (bug) to enhancement

@greuben
10 years ago

attached file has images which should be in wp-includes\js\tinymce\plugins\wplink\css

#2 @greuben
10 years ago

  • Keywords has-patch added

#3 @nacin
10 years ago

Attaching my own patch as well, something I forgot to do (which I wrote for some JS practice). Has some minor todo for sliding, and also has no UI/images toggle, just a dummy link.

@nacin
10 years ago

My incomplete version.

#4 @greuben
10 years ago

Ignore my patch, they are completely different aspect...next time will read the tickets more carefully.

@koopersmith
10 years ago

#5 @ryan
10 years ago

(In [16931]) Expand/collapse in internal linking. Props koopersmith, nacin. see #15739

#6 @ryan
10 years ago

(In [16933]) Internal linking IE tweaks. Props koopersmith. see #15739

#7 @jane
10 years ago

  • Type changed from enhancement to task (blessed)
  • Version set to 3.1

#8 @jane
10 years ago

Needs a little UI love around the expand/collapse before RC. Will discuss with UI group.

#9 @nacin
10 years ago

  • Owner set to JohnONolan
  • Status changed from new to assigned

John will be doing a 4-arrow sprite.

@JohnONolan
10 years ago

Try this on for size and let me know how you get on, can tweak if req'd.

#10 @JohnONolan
10 years ago

  • Keywords ui-feedback added
  • Owner changed from JohnONolan to nacin

#11 @nacin
10 years ago

  • Keywords needs-patch added; has-patch ui-feedback removed
  • Owner nacin deleted

Can someone try whipping up some CSS around this?

#12 follow-up: @nacin
10 years ago

I want to change this string, "Link to Content on this Site", because it looks ridiculous with "C" and "S". The easy option is "Link to content on this site". Do we want to return the word "existing"? It was previously "link to existing site content" before we added the expand/collapse.

So, one of these:

  • "Link to content on this site"
  • "Link to existing content on this site"
  • "Link to existing site content"

#13 @nacin
10 years ago

  • Keywords i18n-change added

#14 follow-up: @ocean90
10 years ago

@JohnONolan
Would be nice if you could change the sprite, so that the images are vertical oriented.

#15 in reply to: ↑ 12 @jane
10 years ago

Replying to nacin:

I want to change this string, "Link to Content on this Site", because it looks ridiculous with "C" and "S".

  • Or link to existing content

#16 in reply to: ↑ 14 @JohnONolan
10 years ago

Replying to ocean90:

@JohnONolan
Would be nice if you could change the sprite, so that the images are vertical oriented.

Sure... just rotate the image 90 degrees in either direction ;)

#17 @nacin
10 years ago

We're also dropping the colon in 'Enter the destination URL' for consistency.

The link around "Or link to existing content" should be dropped. It should still be clickable, but it should be the collapsed arrow inviting a click. I imagine it will be easier to drop the <a> and make the div (or a span the width of the text) clickable, rather than styling the <a> to match body text in terms of color and no underline.

#18 @nacin
10 years ago

(In [17099]) New help strings in internal linking. props jane, see #15739.

#19 @nacin
10 years ago

  • Keywords i18n-change removed

@ocean90
10 years ago

Sprite, place it in wp-includes/js/tinymce/plugins/wplink/img

#20 @ocean90
10 years ago

  • Keywords has-patch added; needs-patch removed

In 15739.drop.link.patch the link is dropped.

#21 @ryan
10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [17117]) Expand/collapse arrows for internal linking. Props ocean90. fixes #15739

#22 @nacin
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening due to stated browser issues and final testing.

#23 @nacin
10 years ago

(In [17118]) The internal linking dialog should be 'Add Link' not 'Save Link'. Not a new string. props jane, see #15739.

#24 @ocean90
10 years ago

15739.fix.background-position.patch will fix the arrow toggle for Firefox and Opera and has a small fix for long titles.

#25 @nacin
10 years ago

(In [17125]) CSS tweaks and arrow fixes for internal linking. props ocean90, see #15739.

#26 @nacin
10 years ago

  • Keywords needs-testing added; has-patch removed

what's left: final browser testing down to IE6, and checking long title handling.

#27 @demetris
10 years ago

I seems to me we have the expand/collapse arrows wrong.

I think the intuitive and common pattern for this case is:

Downwards arrow for showing

Upwards arrow for hiding

Patch forthcoming upon request.

#28 @nacin
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Follow-up testing can be reported to #15561.

Note: See TracTickets for help on using tickets.