WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Closed 16 years ago

#15753 closed defect (bug) (fixed)

Incorrect warning on Network blog setup page.

Reported by: kapeels Owned by:
Priority: normal Milestone: 3.1
Component: General Version:
Severity: trivial Keywords: has-patch needs-testing
Cc: Focuses:

Description

After clicking on the "Install", this warning is shown -

Caution: We recommend you back up your existing wp-config.php and .htaccess files.

even if .htaccess doesn't exist.

Patch attached.

Attachments (4)

network.diff​ (992 bytes ) - added by kapeels 16 years ago.
15753-1.diff​ (1.6 KB ) - added by kapeels 16 years ago.
What about this one?
15753-2.patch​ (1.1 KB ) - added by SergeyBiryukov 16 years ago.
Revised for proper l10n
15753-3.patch​ (1.1 KB ) - added by SergeyBiryukov 16 years ago.
Merged two strings into one

Download all attachments as: .zip

Change History (12)

@kapeels
16 years ago

#1 @nacin
16 years ago

  • Severity normal → trivial

This isn't translatable. But it brings up a good point, you might not have an .htaccess file. But, you might have web.config for IIS.

@kapeels
16 years ago

What about this one?

#2 @kapeels
16 years ago

  • Cc kapeel.sable@… added
  • Keywords needs-testing added

The above works well in Apache. Needs testing on IIS.

@SergeyBiryukov
16 years ago

Revised for proper l10n

#3 @SergeyBiryukov
16 years ago

I doubt that xgettext will build the correct strings from PHP variables. Revised the patch. Removed unnecessary spaces, etc.

#4 @nacin
16 years ago

  • Milestone Awaiting Review → 3.1

#5 @nacin
16 years ago

  • Milestone 3.1 → Awaiting Review

We can turn this into two strings instead of three, by using printf to alternatively include .htaccess or web.config.

#6 @nacin
16 years ago

  • Keywords needs-refresh added; needs-testing removed
  • Milestone Awaiting Review → 3.1

@SergeyBiryukov
16 years ago

Merged two strings into one

#7 @SergeyBiryukov
16 years ago

  • Keywords needs-testing added; needs-refresh removed

Right. Done.

#8 @ryan
16 years ago

  • Resolution → fixed
  • Status new → closed

(In [16921]) Better backup notices. Props SergeyBiryukov, kapeels. fixes #15753

Note: See TracTickets for help on using tickets.