WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15753 closed defect (bug) (fixed)

Incorrect warning on Network blog setup page.

Reported by: kapeels Owned by:
Milestone: 3.1 Priority: normal
Severity: trivial Version:
Component: General Keywords: has-patch needs-testing
Focuses: Cc:

Description

After clicking on the "Install", this warning is shown -

Caution: We recommend you back up your existing wp-config.php and .htaccess files.

even if .htaccess doesn't exist.

Patch attached.

Attachments (4)

network.diff (992 bytes) - added by kapeels 3 years ago.
15753-1.diff (1.6 KB) - added by kapeels 3 years ago.
What about this one?
15753-2.patch (1.1 KB) - added by SergeyBiryukov 3 years ago.
Revised for proper l10n
15753-3.patch (1.1 KB) - added by SergeyBiryukov 3 years ago.
Merged two strings into one

Download all attachments as: .zip

Change History (12)

kapeels3 years ago

comment:1 nacin3 years ago

  • Severity changed from normal to trivial

This isn't translatable. But it brings up a good point, you might not have an .htaccess file. But, you might have web.config for IIS.

kapeels3 years ago

What about this one?

comment:2 kapeels3 years ago

  • Cc kapeel.sable@… added
  • Keywords needs-testing added

The above works well in Apache. Needs testing on IIS.

SergeyBiryukov3 years ago

Revised for proper l10n

comment:3 SergeyBiryukov3 years ago

I doubt that xgettext will build the correct strings from PHP variables. Revised the patch. Removed unnecessary spaces, etc.

comment:4 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.1

comment:5 nacin3 years ago

  • Milestone changed from 3.1 to Awaiting Review

We can turn this into two strings instead of three, by using printf to alternatively include .htaccess or web.config.

comment:6 nacin3 years ago

  • Keywords needs-refresh added; needs-testing removed
  • Milestone changed from Awaiting Review to 3.1

SergeyBiryukov3 years ago

Merged two strings into one

comment:7 SergeyBiryukov3 years ago

  • Keywords needs-testing added; needs-refresh removed

Right. Done.

comment:8 ryan3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16921]) Better backup notices. Props SergeyBiryukov, kapeels. fixes #15753

Note: See TracTickets for help on using tickets.