WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Closed 15 years ago

#15755 closed enhancement (fixed)

Appearance: add action to reset custom background color

Reported by: lancewillett Owned by: nacin
Priority: normal Milestone: 3.2
Component: Themes Version: 3.1
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

In Appearance > Background form there is no way to clear the color hex value other than knowing that you can remove the hex value itself by hand.

Patch adds a "Clear" link that removes the color value using the pickColor method by passing it an empty string.

Attachments (2)

clear-bg-15755.diff​ (3.9 KB ) - added by lancewillett 16 years ago.
clear-bg-15755-refreshed.diff​ (4.0 KB ) - added by lancewillett 15 years ago.
Refreshed patch for trunk as of r17707

Download all attachments as: .zip

Change History (9)

@lancewillett
16 years ago

#1 @nacin
16 years ago

  • Keywords 3.2-early added
  • Milestone Awaiting Review → Future Release

#3 @lancewillett
15 years ago

  • Cc lance@… added

@nacin Would it be OK to get this into 3.2 now?

@lancewillett
15 years ago

Refreshed patch for trunk as of r17707

#4 follow-up: @nacin
15 years ago

  • Keywords 3.2-early removed
  • Milestone Future Release → 3.2
  • Owner set to nacin
  • Status new → reviewing

We can probably pull the CSS into the header, rather than inline.

In the future, no need to do compressed styles/scripts. We handle those on commit.

#5 in reply to: ↑ 4 @lancewillett
15 years ago

Replying to nacin:

In the future, no need to do compressed styles/scripts. We handle those on commit.

Noted, thanks.

#6 @ryan
15 years ago

Redacted comment. Wrong ticket.

Last edited 15 years ago by ryan (previous) (diff)

#7 @nacin
15 years ago

  • Resolution → fixed
  • Status reviewing → closed

In [17886]:

Add clear to custom background color field. props lancewillett for initial patch. fixes #15755.

Note: See TracTickets for help on using tickets.