WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#15755 closed enhancement (fixed)

Appearance: add action to reset custom background color

Reported by: lancewillett Owned by: nacin
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.1
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

In Appearance > Background form there is no way to clear the color hex value other than knowing that you can remove the hex value itself by hand.

Patch adds a "Clear" link that removes the color value using the pickColor method by passing it an empty string.

Attachments (2)

clear-bg-15755.diff (3.9 KB) - added by lancewillett 7 years ago.
clear-bg-15755-refreshed.diff (4.0 KB) - added by lancewillett 7 years ago.
Refreshed patch for trunk as of r17707

Download all attachments as: .zip

Change History (9)

#1 @nacin
7 years ago

  • Keywords 3.2-early added
  • Milestone changed from Awaiting Review to Future Release

#3 @lancewillett
7 years ago

  • Cc lance@… added

@nacin Would it be OK to get this into 3.2 now?

@lancewillett
7 years ago

Refreshed patch for trunk as of r17707

#4 follow-up: @nacin
7 years ago

  • Keywords 3.2-early removed
  • Milestone changed from Future Release to 3.2
  • Owner set to nacin
  • Status changed from new to reviewing

We can probably pull the CSS into the header, rather than inline.

In the future, no need to do compressed styles/scripts. We handle those on commit.

#5 in reply to: ↑ 4 @lancewillett
7 years ago

Replying to nacin:

In the future, no need to do compressed styles/scripts. We handle those on commit.

Noted, thanks.

#6 @ryan
7 years ago

Redacted comment. Wrong ticket.

Last edited 7 years ago by ryan (previous) (diff)

#7 @nacin
7 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In [17886]:

Add clear to custom background color field. props lancewillett for initial patch. fixes #15755.

Note: See TracTickets for help on using tickets.