wp-admin/ms-sites.php doesn't indicate required fields

[novasource]

In wp-admin/ms-sites.php, apparently all fields under Add Site are required, but there is no visual indication.

[ocean90]

With 3.1 it's wp-admin/network/site-new.php.

[wonderboymusic]

Added required using same HTML as the edit-user.php form, including label with the for attribute. Patched.

[toscho]

Add 'required' attribute to prevent accidental submissions. Fix code style violations en passant.

[toscho]

To prevent useless submissions I have added the required attribute. Browsers supporting this will show a warning message, and they will prevent a form submission.

[DrewAPicture]

15765.2.patch​ combines required-fields.diff with just adding the required attributes to the three inputs.

[nacin]

I don't see us using required HTML attributes anywhere else. Not saying we shouldn't, but — new ticket to cover the more general case?

[nacin]

Is this a situation where we don't do it when all fields are required? That seems to be the pattern on user-new.php. In which case, wontfix?

[jeremyfelt]

I'm able to add a site on current trunk without a title for a subdomain setup. The fields required are Site Address and Admin Email. Without a title specified, the site is just referred to as its address.

Having a required indicator next to these is probably much better than the experience provided by the error that comes up on the next screen if you don't fill one in properly.

15765.3.diff​ removes the required flags from Site Title added in previous patches.

[jeremyfelt]

On a side note... while not required, adding multiple sites under a subdirectory setup without titles would cause confusion quickly.

​http://cl.ly/image/2J470i0C3H0A

In the screenshot, both src.wordpress-develop.dev listings have different subdirectory paths specified. SRC Dev is the original site.

[nacin]

Listing all but one field as "required" is weird. When that single remaining field is a de facto requirement, I guess I just don't see the point at all.

This has been kicking around for a while, moving out of 3.7 either way.

[helen]

I usually like required field indicators but it seems like extraneous noise when all fields are required. It would be nice to have better error handling than wp_die() though (not just here, everywhere). I'm going to maybelater this, but will leave a note on #20592 that if hooks are added, we will probably want to revisit.