WordPress.org

Make WordPress Core

Changes between Initial Version and Version 3 of Ticket #15773


Ignore:
Timestamp:
12/13/2010 08:20:05 PM (7 years ago)
Author:
scribu
Comment:

You are missing something, yeah, but it's my fault. Updated ticket for clarity.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15773

    • Property Keywords php5 has-patch added
    • Property Cc gazouteast added
    • Property Summary changed from Drop $is_singular to Replace $is_singular with is_singular()
  • Ticket #15773 – Description

    initial v3  
    1 The $is_singular flag is just an alias for $is_post || $is_page || $is_attachment.
     1The $is_singular flag is just an alias for {{{$is_post || $is_page || $is_attachment.}}}
    22
    33Being a variable means we have to also keep it current whenever one of it's components changes.
    44
    5 But since we have an is_singular() method now, we could deprecate it.
     5I propose we use the is_singular() method, and deprecate $is_singular.