Make WordPress Core

Opened 16 years ago

Closed 16 years ago

#15795 closed enhancement (fixed)

Press This should support post formats

Reported by: nacin Owned by: greuben
Priority: normal Milestone: 3.1
Component: Press This Version: 3.1
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description (last modified by nacin)


Attachments (7)

reuben-15795.diff (1.9 KB ) - added by greuben 16 years ago.
15795-2.diff (2.0 KB ) - added by greuben 16 years ago.
15795-3.diff (2.2 KB ) - added by greuben 16 years ago.
15795-4.diff (2.1 KB ) - added by greuben 16 years ago.
post formats in select box and with missing post/save login
15795.diff (2.2 KB ) - added by nacin 16 years ago.
Patch refreshed with some minor code and UI changes.
15795.2.diff (2.2 KB ) - added by nacin 16 years ago.
Fixing some self-closed option elements.
15795.3.diff (2.3 KB ) - added by nacin 16 years ago.

Download all attachments as: .zip

Change History (22)

#1 @scribu
16 years ago

I don't mean to rub it in, but: #14650 :)

#2 @nacin
16 years ago

All for it. Even at the time I triaged it, it was a bit late for 3.1 though.

#3 @scribu
16 years ago

We had something like this in 2.5, no?

#4 @greuben
16 years ago

  • Keywords has-patch added

#5 @nacin
16 years ago

  • Keywords needs-patch added; has-patch removed

Patch is missing some important bits that we see in post.php, such as theme support checks.

@greuben
16 years ago

@greuben
16 years ago

#6 @nacin
16 years ago

  • Priority normalhighest omg bbq

Per IRC discussion, let's go with a select box as a compromise for 3.1. Otherwise press this can't actually support this in terms of space.

I'm still not sure the POST handler logic is complete.

@greuben
16 years ago

post formats in select box and with missing post/save login

#7 @greuben
16 years ago

  • Keywords has-patch added; needs-patch removed

with missing post/save logic

#8 @nacin
16 years ago

  • Owner set to greuben
  • Status newassigned

Looks good. Will review it tomorrow and give it a good tire kicking.

Assigning an owner so we can keep track of who is iterating the final tickets.

#9 @nacin
16 years ago

Will ask Jane if she can agree to these changes: http://cl.ly/350l0S1O3L0M1P1F2U0W.

For reference, here's the 3.0 version: http://cl.ly/1Q0u2B2g0C2H1E2y1F0a. (Of note, the publish box could not be moved or collapsed. Removing the redundant title is not the end of the world.)

@nacin
16 years ago

Patch refreshed with some minor code and UI changes.

#10 @nacin
16 years ago

  • Keywords commit added

Approved and tested.

@nacin
16 years ago

Fixing some self-closed option elements.

@nacin
16 years ago

#11 @nacin
16 years ago

Patch updated against default post formats in #15882.

Just needs final review.

#12 @jane
16 years ago

  • Description modified (diff)
  • Priority highest omg bbqnormal

If Press This automatically used the default post status in v1 of post formats, it would have been fine, so I'm putting the priority back to normal.

Last edited 16 years ago by nacin (previous) (diff)

#13 @nacin
16 years ago

  • Description modified (diff)

#14 @ryan
16 years ago

Looks good.

#15 @nacin
16 years ago

  • Resolutionfixed
  • Status assignedclosed

(In [17065]) Support post formats in Press This. fixes #15795, props greuben for initial patch.

Note: See TracTickets for help on using tickets.