WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15795 closed enhancement (fixed)

Press This should support post formats

Reported by: nacin Owned by: greuben
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Press This Keywords: has-patch commit
Focuses: Cc:

Attachments (7)

reuben-15795.diff (1.9 KB) - added by greuben 3 years ago.
15795-2.diff (2.0 KB) - added by greuben 3 years ago.
15795-3.diff (2.2 KB) - added by greuben 3 years ago.
15795-4.diff (2.1 KB) - added by greuben 3 years ago.
post formats in select box and with missing post/save login
15795.diff (2.2 KB) - added by nacin 3 years ago.
Patch refreshed with some minor code and UI changes.
15795.2.diff (2.2 KB) - added by nacin 3 years ago.
Fixing some self-closed option elements.
15795.3.diff (2.3 KB) - added by nacin 3 years ago.

Download all attachments as: .zip

Change History (22)

comment:1 scribu3 years ago

I don't mean to rub it in, but: #14650 :)

comment:2 nacin3 years ago

All for it. Even at the time I triaged it, it was a bit late for 3.1 though.

comment:3 scribu3 years ago

We had something like this in 2.5, no?

greuben3 years ago

comment:4 greuben3 years ago

  • Keywords has-patch added

comment:5 nacin3 years ago

  • Keywords needs-patch added; has-patch removed

Patch is missing some important bits that we see in post.php, such as theme support checks.

greuben3 years ago

greuben3 years ago

comment:6 nacin3 years ago

  • Priority changed from normal to highest omg bbq

Per IRC discussion, let's go with a select box as a compromise for 3.1. Otherwise press this can't actually support this in terms of space.

I'm still not sure the POST handler logic is complete.

greuben3 years ago

post formats in select box and with missing post/save login

comment:7 greuben3 years ago

  • Keywords has-patch added; needs-patch removed

with missing post/save logic

comment:8 nacin3 years ago

  • Owner set to greuben
  • Status changed from new to assigned

Looks good. Will review it tomorrow and give it a good tire kicking.

Assigning an owner so we can keep track of who is iterating the final tickets.

comment:9 nacin3 years ago

Will ask Jane if she can agree to these changes: http://cl.ly/350l0S1O3L0M1P1F2U0W.

For reference, here's the 3.0 version: http://cl.ly/1Q0u2B2g0C2H1E2y1F0a. (Of note, the publish box could not be moved or collapsed. Removing the redundant title is not the end of the world.)

nacin3 years ago

Patch refreshed with some minor code and UI changes.

comment:10 nacin3 years ago

  • Keywords commit added

Approved and tested.

nacin3 years ago

Fixing some self-closed option elements.

nacin3 years ago

comment:11 nacin3 years ago

Patch updated against default post formats in #15882.

Just needs final review.

comment:12 jane3 years ago

  • Description modified (diff)
  • Priority changed from highest omg bbq to normal
Version 0, edited 3 years ago by jane (next)

comment:13 nacin3 years ago

  • Description modified (diff)

comment:14 ryan3 years ago

Looks good.

comment:15 nacin3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [17065]) Support post formats in Press This. fixes #15795, props greuben for initial patch.

Note: See TracTickets for help on using tickets.