Make WordPress Core

Opened 5 years ago

Last modified 5 years ago

#15795 closed enhancement

Press This should support post formats — at Version 13

Reported by: nacin Owned by: greuben
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Press This Keywords: has-patch commit
Focuses: Cc:

Change History (20)

comment:1 @scribu5 years ago

I don't mean to rub it in, but: #14650 :)

comment:2 @nacin5 years ago

All for it. Even at the time I triaged it, it was a bit late for 3.1 though.

comment:3 @scribu5 years ago

We had something like this in 2.5, no?

@greuben5 years ago

comment:4 @greuben5 years ago

  • Keywords has-patch added

comment:5 @nacin5 years ago

  • Keywords needs-patch added; has-patch removed

Patch is missing some important bits that we see in post.php, such as theme support checks.

@greuben5 years ago

@greuben5 years ago

comment:6 @nacin5 years ago

  • Priority changed from normal to highest omg bbq

Per IRC discussion, let's go with a select box as a compromise for 3.1. Otherwise press this can't actually support this in terms of space.

I'm still not sure the POST handler logic is complete.

@greuben5 years ago

post formats in select box and with missing post/save login

comment:7 @greuben5 years ago

  • Keywords has-patch added; needs-patch removed

with missing post/save logic

comment:8 @nacin5 years ago

  • Owner set to greuben
  • Status changed from new to assigned

Looks good. Will review it tomorrow and give it a good tire kicking.

Assigning an owner so we can keep track of who is iterating the final tickets.

comment:9 @nacin5 years ago

Will ask Jane if she can agree to these changes: http://cl.ly/350l0S1O3L0M1P1F2U0W.

For reference, here's the 3.0 version: http://cl.ly/1Q0u2B2g0C2H1E2y1F0a. (Of note, the publish box could not be moved or collapsed. Removing the redundant title is not the end of the world.)

@nacin5 years ago

Patch refreshed with some minor code and UI changes.

comment:10 @nacin5 years ago

  • Keywords commit added

Approved and tested.

@nacin5 years ago

Fixing some self-closed option elements.

@nacin5 years ago

comment:11 @nacin5 years ago

Patch updated against default post formats in #15882.

Just needs final review.

comment:12 @jane5 years ago

  • Description modified (diff)
  • Priority changed from highest omg bbq to normal

If Press This automatically used the default post status in v1 of post formats, it would have been fine, so I'm putting the priority back to normal.

Last edited 5 years ago by nacin (previous) (diff)

comment:13 @nacin5 years ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.