Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #15800, comment 25


Ignore:
Timestamp:
03/06/2016 07:14:04 PM (6 years ago)
Author:
johnjamesjacoby
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15800, comment 25

    initial v1  
    1616* Is the output buffer absolutely necessary? No, but I like the idea of batching this output and rendering it all at once. Why do this? In the unlikely event of OOM errors, no tabs render vs partial or incomplete tabs. It also prevents jumpiness on slow connections while tabs are looped through and echo'ed. I have a tendency to do this with most loops that shouldn't communicate to the user if an interruption occurs, so I included that philosophy here. WordPress core also does this in several places already, though I consider it an unwritten rule.
    1717* I have a somewhat selfishly urgent need to see this happen in 4.6-early, so whatever I can do to get yay/nay from interested parties and a sign-off from Jeremy, I will keep an eye on this and shepherd as needed.
     18* Lastly, is the function name `network_edit_site_tabs()` acceptable to everyone? All possible function names I can think of for this function are equally bad. `wp_network_site_edit_tabs()` `wp_network_edit_site_tabs()` `maybe_wpms_site_edit_tabs_are_too_big()` et all