WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #15800, comment 31


Ignore:
Timestamp:
04/18/2016 08:19:56 PM (6 years ago)
Author:
johnjamesjacoby
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15800, comment 31

    initial v1  
    22
    33* I'm fine doing that elsewhere, but we'll need to be doubly sure we don't make any mistakes during the fork and merge of these two initiatives
    4 * The way we've been doing this everywhere else is to make these screens objects, but we can't easily have more than 1 'WP_Screen` object hanging around at any one time. I think because these tabs are put out at run time vs. precompiled on `init` or elsewhere, doing this late is the only place we currently have without inventing a new place
     4* The way we've been doing this everywhere else is to make these screens objects, but we can't easily have more than 1 `WP_Screen` object hanging around at any one time. I think because these tabs are put out at run time vs. precompiled on `init` or elsewhere, doing this late is the only place we currently have without inventing a new place
    55* It looks fine until you start to have no tabs, which indicates something has gone horribly wrong. We should account for this, but it would require manually unsetting something in a forceful way, which makes me inclined to think someone doing that wants that level of control.
    66* I know we don't do this in very many places anymore, but considering this is duplicated logic across 4 (or more) files, it felt right to put it inside the function. Once it was in there, I could imagine core wanting to modify this in the future, and/or plugins wanting to go even further into modifying the tabbed interface into something else. Naturally, I'm doing this, so I find it pretty useful as it is.