Make WordPress Core

Opened 3 years ago

Last modified 3 months ago

#15801 assigned defect (bug)

Network Admin: Deactivated / Deleted inconsistency

Reported by: kawauso Owned by: nacin
Milestone: Future Release Priority: normal
Severity: normal Version: 3.1
Component: Networks and Sites Keywords: has-patch
Focuses: multisite Cc:


Under the Sites screen, there are distinct inline links for Deactivate and Delete. However, when a site is deactivated, it is referred to as deleted in:

  • Sites screen inline status
  • Edit Site screen attributes section
  • Error page for non-admins visiting the site

Attachments (1)

deactivated.diff (629 bytes) - added by wonderboymusic 18 months ago.

Download all attachments as: .zip

Change History (24)

comment:1 kawauso3 years ago

  • Severity changed from minor to normal

Leaving severity alone

comment:2 nacin3 years ago

  • Component changed from UI to Network Admin
  • Milestone changed from Awaiting Review to 3.1

comment:3 PeteMall3 years ago

  • Owner set to PeteMall
  • Status changed from new to assigned

comment:4 ryan_b3 years ago

  • Cc ryan_b added

comment:5 ryan_b3 years ago

From what I can tell, the delete link removes the site from the db, deactivate leaves it in the db and sets a flag called "deleted", so my question is if the flag is called deleted is the status being listed as "Deleted" the desired effect?

comment:6 ryan_b3 years ago

  • Keywords dev-feedback added

comment:7 ryan3 years ago

  • Milestone changed from 3.1 to Future Release

comment:8 scribu3 years ago

Related: #17164

comment:9 novasource3 years ago

  • Cc aren@… added

comment:10 wonderboymusic18 months ago

  • Keywords has-patch added; dev-feedback removed
  • Milestone changed from Future Release to 3.5

Deactivated is the status for the Delete flag, Delete is an action that removes the site. Patched.

comment:11 nacin18 months ago

  • Milestone changed from 3.5 to Future Release

There's a lot of inconsistency here. Moving out of 3.5 for further review.

comment:12 knutsp17 months ago

  • Cc knut@… added

comment:13 wonderboymusic16 months ago

  • Milestone changed from Future Release to 3.6

comment:14 DrewAPicture12 months ago

  • Component changed from Network Admin to Text Changes

deactivated.diff looks good to me. It's a shame the flag is called 'deleted' but I'd assume changing it isn't an option.

comment:15 wonderboymusic10 months ago

  • Milestone changed from 3.6 to Future Release

comment:16 wonderboymusic9 months ago

  • Keywords easy-fix added
  • Milestone changed from Future Release to 3.7

comment:17 martythornley8 months ago

It seems there is still an inconsistency in that from a user's POV, they go through the process of saying to 'delete' their site, which is why it now shows up as 'deleted' but from the super admin POV it is really deactivated.

So... we could either change the "delete" link from the Super Admin level and rename it to "remove" or "permanently delete", then change the "deactivate" link back to "delete". This would make user and super admin "delete" functions act the same. "Delete" would mean temporary, like moving to the trash. While "Remove" or "Permanently Delete" would remove it altogether.

comment:18 SergeyBiryukov8 months ago

  • Keywords easy-fix removed

"easy-fix" is a tag for attracting new contributors to tickets that don't have a patch yet.

See the IRC discussion: part 1, part 2.

comment:19 martythornley8 months ago

I played with some of the wording in those links and some seem to work better than others.

It seems from the user level, they go through the delete site process and to them the site is gone. But really to the Super Admin it is "marked for deletion" which seems an even better label to me than "deactivated".

As a Super Admin, when we deactivate and reactivate a site, it is like trash/untrash or again, marking for possible deletion.

Once sites are "marked for deletion" or in the trash, we can use the "Delete" link to do it permanently.

Changing the wording of the links makes the super admin process make more sense, but it starts messing with the flags and would be inconsistent when looking at the code.

However, the get_blog_status and update_blog_status are only called a couple times in core and it would seem to not too difficult to run a quick update that says if the blog status is called 'deleted' update that to 'trash'. Or whatever the decided wording is. Or am I missing other areas that rely on those flags?

Another, farther reaching idea...

Could we somehow change the blog status to an array that can be whatever we want? That way a blog could be multiple things at once - A blog could be 'Mature', "Spam', and 'Trash" all at once? Or any number of custom status that a plugin might build like "Awesome", "Promoted", etc...

comment:20 nacin7 months ago

  • Component changed from Text Changes to Multisite
  • Milestone changed from 3.7 to 3.8
  • Owner changed from PeteMall to nacin

comment:21 jeremyfelt5 months ago

The behavior makes sense in that a user (not a superadmin) is flagging or marking their site for deletion, not deleting it directly. If the language to the user was updated to better convey this, that might be all that is needed.

The post delete screen of Your site will not be deleted until this link is clicked. could become Your site will not be flagged for deletion until this link is clicked.

An explanation about the network administrator having to complete the process could be added to the delete email.

The text for a non logged-in user *could* stay the same - This user has elected to delete their account and the content is no longer available. or could be changed to This site has been marked for deletion and the content is no longer available. It is the site being deleted, not necessarily the user's account.

And finally, the Deleted marker in the network admin's list table could be left alone or something else could be done to convey that further action is needed to satisfy the user's wishes.

@nacin - do you have thoughts on approach with this? Not sure if it really is something we can squeeze into 3.8.

comment:22 nacin5 months ago

  • Milestone changed from 3.8 to Future Release

@nacin - do you have thoughts on approach with this? Not sure if it really is something we can squeeze into 3.8.

Not really. Let's play a long game here. What's the best approach? Let's figure it out and do it, versus trying to squeeze things into a release over a confusing label.

comment:23 jeremyfelt3 months ago

  • Component changed from Multisite to Networks and Sites
  • Focuses multisite added
Note: See TracTickets for help on using tickets.