get_terms with hide_empty returns count > 0 with unpublished items

[bendog]

Hi,

I think that's a bug.

I've defined a custom post type and a custom category taxonomy for it.

On my front end, i'm using get_terms with hide_empty to show the categories of the existing custom post type.

get_terms does ignore unpublished posts but it seems to include trashed item.

I have one category that is linked to only a trashed item and the function includes it in the count.

I can't select 3.0.3 in the version dropdown but it happened on any 3.0.x that I tried.

[neoxx]

In 3.2 I could also reproduce the bug with an unpublished post in combination with an otherwise not assigned custom taxonomy term. (get_terms w/ hide_empty)

[vtowel]

I could also reproduce this bug with posts pending approval. Their tags/categories shouldn't show up in the front end if those tags/categories are otherwise unused by published posts. Even better would be for get_terms to have an option specifying desired post status, "publish" being the default value.

[jtwg]

Just ran into this same problem. Custom post type with custom taxonomy, custom taxonomy returning results with posts in trash.

[jgadbois]

Seems like either a join will be needed in get_terms() or wp_update_term_count_now() will need to be modified to only count terms tied to published posts. This second method will also require counts to be updated when post status changes.

I'd be happy to look at this one...anyone want to chime in as to which approach would be preferred?

[paudelvinay]

Is there any progress on get_terms with unpublished post/private posts for custom taxonomy?

[SergeyBiryukov]

Version number indicates when the bug was initially introduced/reported.

[barrykooij]

I tried to reproduce this bug in version 3.6-alpha-23791 and it appears to be working correctly now.

[fetard]

The problem is still present in 4.5.3 (with custom taxonomy and custom post type)

[ocean90]

@fetard Hi, can you provide the code you're using and/or steps to reproduce this issue?

[boonebgorges]

I can't reproduce the issue .15806.diff​ includes tests for a number of situations, all of which seem to work as expected: 'draft' posts are excluded, posts that transition from 'publish' to 'draft' are excluded, posts that transition from 'publish' to 'trash' are excluded.

In his comment above, @ocean90 asked for details to reproduce. Specifically, it would be helpful to see the code used to register the post type and taxonomy. If the post type is providing its own update_count_callback, then it needs to be responsible for its own resetting of term counts.

[boonebgorges]

Closing as per https://core.trac.wordpress.org/ticket/15806#comment:13