When using fancy URIs, using a query string shows the front page

[markjaquith]

As reported by Andy Skelton on wp-testers:
​http://comox.textdrive.com/pipermail/wp-testers/2005-August/000375.html

---

Hi guys and gals, I guess I should have subscribed to this list ages
ago. Now one of my BOTD plugin testers is having an issue with
1.6-ALPHA-2.

My plugin depends on the ability to receive query strings on permalink
pages. This was seamless in 1.5 in almost all cases; only some sites
with index.php in the permalink structure would lose additional query
strings.

Now, whenever I add a query string to a rewrite-enabled permalink URL,
the query string is preserved in $_GETfoo? but is_single() is FALSE
and is_home() is TRUE. This causes WP to load the home template with
the default query and, less critically, it causes problems with my
plugin.

I dug a little deeper and found $wp_query->query and
$wp_query->query_vars coming up blank when I do something like this:
​http://gilford.textdrive.com/~acskelto/2005/08/07/hello-world/?foo=bar
so instead of showing the "Hello, World!" post, it shows the home page.

---

I looked into this with Owen Winkler and we managed to fix it. The solution was to remove the empty($_SERVERQUERY_STRING?) requirement of the rewrite engine, and to strip off everything after "?" in $req_uri and $pathinfo

We tested, and it seems to work just fine. Please test this patch and report any problems.

[markjaquith]

classes.php patch for current 1.6 SVN

[skeltoac]

This diff does resolve the problem I was having. Thank you.

[ryan]

(In [2823]) Allow query strings at the end of cruftless URIs. Props Owen and Mark. fixes #1581

[(none)]

Milestone 2.0 deleted