WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#15810 closed defect (bug) (fixed)

Dashboard comment reply doesn't work: wheel keeps rolling

Reported by: garyc40 Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Comments Keywords: has-patch needs-testing
Focuses: Cc:

Description

If you go to dashboard, and reply to a comment, the wheel keeps rolling, but there's no response. Refreshing the dashboard shows that the reply is there already.

The response from admin-ajax.php includes this:

Notice: Undefined variable: mode in wp-admin/admin-ajax.php on line 667

Attachments (2)

garyc40-15810.patch (443 bytes) - added by garyc40 5 years ago.
there's a patch for that
reuben-15810.diff (562 bytes) - added by greuben 5 years ago.
adding back what was removed while fixing #15580

Download all attachments as: .zip

Change History (9)

comment:1 @garyc405 years ago

  • Keywords needs-patch added

comment:2 @ocean905 years ago

  • Component changed from General to Comments
  • Milestone changed from Awaiting Review to 3.1
  • Version set to 3.1

@garyc405 years ago

there's a patch for that

comment:3 @garyc405 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

comment:4 @ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16914]) Fix notice in ajax response. Props garyc40. fixes #15810

comment:5 @ryan5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Would be nice to see what changed since 3.0.

comment:6 @garyc405 years ago

In 3.0.3, line 747, 748:

$modes = array( 'single', 'detail', 'dashboard' );
$mode = isset($_POST['mode']) && in_array( $_POST['mode'], $modes ) ? $_POST['mode'] : 'detail';

In current trunk:

if ( 'dashboard' == $_REQUEST['mode'] ) {

A diff search from r16807 (3.0.3) to r16914 (current trunk) yields this:
http://core.trac.wordpress.org/changeset?old_path=/trunk/wp-admin/admin-ajax.php&old=16807&new_path=/trunk/wp-admin/admin-ajax.php&new=16914

Absolutely no diff that represents changes from 3.0.3 to current trunk.

From what I learnt, $mode here refers to the comment reply form mode in wp_comment_reply() . It's just for checking whether the reply comes from the dashboard ($mode = 'dashboard'), admin comments page ($mode = 'detail') etc.

@greuben5 years ago

adding back what was removed while fixing #15580

comment:7 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Changed in [16617]. This looks good as is now.

Note: See TracTickets for help on using tickets.