WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#15818 closed enhancement (maybelater)

Insert Into Post button doesn't display for post types without editor support

Reported by: johnbillion Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: TinyMCE Keywords:
Focuses: Cc:

Description

A post type that does not have support for 'editor' may still display a visual editor on the screen by other means (eg. in a custom meta box).

In this situation, the 'Insert Into Post' button doesn't appear in the media uploader/browser lightbox [1]. This means it's not possible to insert media into the post from the media lightbox.

This happens because the 'Insert Into Post' button only shows up if the post type supports 'editor' [2].

Not sure best way to fix this. Suggestions?

[1] http://lists.automattic.com/pipermail/wp-hackers/2010-December/036511.html
[2] http://lists.automattic.com/pipermail/wp-hackers/2010-December/036728.html

Change History (3)

comment:1 @ryan_b4 years ago

  • Cc ryan_b added

From the sounds lf it, having skimmed though the mailing list topic and reading this ticket, it seems that additinal code was needed to get the button to insert images anyway was needed, thus it seems to me that if you get to where you insert the image why does it need to check for a custom post type using the builtin editor, couldn't it just show the button without doing that check at all, or am I missing something.

comment:2 @koopersmith4 years ago

  • Resolution set to maybelater
  • Status changed from new to closed
  • Type changed from defect (bug) to enhancement

We declare support for the editor for a reason. For the time being, if 'Insert Into Post' is necessary for you, I'd suggest supporting the editor and attempting to use its contents/manipulate it in a creative fashion.

Perhaps this will be improved when media is overhauled.

comment:3 @nacin4 years ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.