WordPress.org
Get WordPress

Make WordPress Core

Opened 20 years ago

Closed 19 years ago

Last modified 18 years ago

#1582 closed defect (bug) (wontfix)

user_login table Vs. comment_author table different sizes.

Reported by: j2000_ca's profile J2000_ca Owned by: markjaquith's profile markjaquith
Milestone: Priority: normal
Severity: minor Version: 1.5.2
Component: Optimization Keywords: bg|has-patch bg|commit
Focuses: Cc:

Description

user_login is a varchar(60), while comment_author is tinytext. It would be nice if they were both the same type. varchar(60) is probably big enough for both of them.

Attachments (1)

upgrade-schema.php​ (580 bytes) - added by markjaquith 20 years ago.
Patch against 1.6 SVN

Download all attachments as: .zip

Change History (5)

@markjaquith
20 years ago

Patch against 1.6 SVN

#1 @markjaquith
20 years ago

  • Keywords bg|has-patch bg|dev-feedback added
  • Milestone set to 1.6
  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

Patch fixes it. Nice catch.

(devs: it appears that upgrade-schema.php is the only place I need to change it, because of that rockin' dbDelta() function. Is that correct?)

#2 @markjaquith
20 years ago

  • Keywords bg|commit added; bg|dev-feedback removed
  • Version changed from 1.5.1.2 to 1.5.2

#3 @matt
19 years ago

  • Resolution set to wontfix
  • Status changed from assigned to closed

comment_author needs to be tinytext because trackback and pingabck author values can get really long.

#4 @(none)
18 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.