Make WordPress Core

Opened 14 years ago

Closed 10 years ago

#15827 closed defect (bug) (duplicate)

AJAX paging breaks badly when json_encode can't encode

Reported by: westi's profile westi Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords: has-patch dev-feedback
Focuses: Cc:


If json_encode can't encode a response for some reason you get no feedback at all except for a blank list.

This seems most likely to trigger with invalid UTF8 sequences in spam comments.

With non-ajax paging you at least get all the comments displayed even if you do get a lot of ??? for the bad chars

Example Error seen:

[15-Dec-2010 14:18:38] Warning: json_encode() [<a href='function.json-encode'>function.json-encode</a>]: Invalid UTF-8 sequence in argument in /home/wpdev/public_html/wp-admin/includes/class-wp-list-table.php on line 839 [

Attachments (2)

15827.patch (1.1 KB) - added by SergeyBiryukov 13 years ago.
15827.diff (1.1 KB) - added by MikeHansenMe 10 years ago.

Download all attachments as: .zip

Change History (10)

#1 @filosofo
14 years ago

This is one reason I proposed a standard way of doing Ajax in #14618: it handles erroneous or syntactically invalid responses in a consistent manner.

In this case we could pass the href attribute value to the error handler and have it set location.href to load the requested page when Ajax paging fails.

#2 @ryan
14 years ago

  • Milestone changed from 3.1 to Future Release

#3 @SergeyBiryukov
13 years ago

We can strip invalid characters with wp_check_invalid_utf8(). Patch included.

Last edited 13 years ago by SergeyBiryukov (previous) (diff)

#4 @SergeyBiryukov
13 years ago

  • Keywords has-patch added

#5 @scribu
13 years ago

  • Cc scribu added
  • Owner scribu deleted
  • Status changed from new to assigned

10 years ago


#7 @chriscct7
10 years ago

  • Keywords dev-feedback added

#8 @pento
10 years ago

  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from assigned to closed

Duplicate of #28786.

Note: See TracTickets for help on using tickets.