WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#15830 closed defect (bug) (fixed)

'editor' script depends on jQuery, but doesn't register it as a dependency

Reported by: jczorkmid Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords: has-patch
Focuses: Cc:

Attachments (2)

script-loader.diff (586 bytes) - added by jczorkmid 10 years ago.
patch
15830.diff (594 bytes) - added by JohnPBloch 10 years ago.

Download all attachments as: .zip

Change History (7)

@jczorkmid
10 years ago

patch

#1 @jczorkmid
10 years ago

  • Keywords has-patch added

#2 @nacin
10 years ago

  • Milestone changed from Awaiting Review to 3.1

#3 @JohnPBloch
10 years ago

  • Keywords has-patch removed

Just tested the patch. In Chrome on Mac I got this error when enqueueing editor.js:

Uncaught ReferenceError: wpCookies is not defined

Adding 'utils' as an extra dependency fixes the error. Patch coming in a second.

@JohnPBloch
10 years ago

#4 @JohnPBloch
10 years ago

  • Keywords has-patch added

#5 @ryan
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17000]) Add jquery and utils dependencies for editor js. Props JohnPBloch, jczorkmid. fixes #15830

Note: See TracTickets for help on using tickets.