WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Closed 16 years ago

#15830 closed defect (bug) (fixed)

'editor' script depends on jQuery, but doesn't register it as a dependency

Reported by: jczorkmid Owned by:
Priority: normal Milestone: 3.1
Component: Administration Version: 3.1
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

source:/trunk/wp-admin/js/editor.js@16394#L1​ (source:/trunk/wp-admin/js/editor.dev.js@16394#L2​) relies on jQuery, but it doesn't register it as a dependency in source:/trunk/wp-includes/script-loader.php@16943#L94​

Attachments (2)

script-loader.diff​ (586 bytes ) - added by jczorkmid 16 years ago.
patch
15830.diff​ (594 bytes ) - added by JohnPBloch 16 years ago.

Download all attachments as: .zip

Change History (7)

@jczorkmid
16 years ago

patch

#1 @jczorkmid
16 years ago

  • Keywords has-patch added

#2 @nacin
16 years ago

  • Milestone Awaiting Review → 3.1

#3 @JohnPBloch
16 years ago

  • Keywords has-patch removed

Just tested the patch. In Chrome on Mac I got this error when enqueueing editor.js:

Uncaught ReferenceError: wpCookies is not defined

Adding 'utils' as an extra dependency fixes the error. Patch coming in a second.

@JohnPBloch
16 years ago

#4 @JohnPBloch
16 years ago

  • Keywords has-patch added

#5 @ryan
16 years ago

  • Resolution → fixed
  • Status new → closed

(In [17000]) Add jquery and utils dependencies for editor js. Props JohnPBloch, jczorkmid. fixes #15830

Note: See TracTickets for help on using tickets.