WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#15834 closed defect (bug) (fixed)

Plugin action links are missing on plugins list, if the screen is to small.

Reported by: ocean90 Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: UI Keywords: has-patch commit
Focuses: Cc:

Description

So, break it please.

Attachments (3)

15834.patch (528 bytes) - added by ocean90 10 years ago.
15834.2.patch (685 bytes) - added by ocean90 10 years ago.
'.plugins .action-links' is not needed anymore too.
test-plugin-action-links.php (203 bytes) - added by scribu 10 years ago.

Download all attachments as: .zip

Change History (18)

@ocean90
10 years ago

#1 @nacin
10 years ago

Screenshot?

#2 @ocean90
10 years ago

http://grab.by/7UP3 - Delete and Edit links are missing.

#3 @nacin
10 years ago

That sounds like an overflow:hidden that needs to be removed, rather than removing nowrap.

Not sure what else nowrap might cause -- side-effects are possible.

#4 @scribu
10 years ago

  • Cc scribu added

#5 @scribu
10 years ago

Ideally, the action links would expand the column width as necessary. Don't think that's possible in a <table>, though.

#6 @nacin
10 years ago

Can someone do some more digging here today?

#7 @ocean90
10 years ago

It's not only the action links, also the plugin title will be hidden, if there is not enough space.

Version 0, edited 10 years ago by ocean90 (next)

#8 @ocean90
10 years ago

I can't see a problem with my patch here. It's the same behavior like on network/themes, network/users, network/sites.

@ocean90
10 years ago

'.plugins .action-links' is not needed anymore too.

#9 @ryan
10 years ago

#8810 for some history

#10 @scribu
10 years ago

  • Keywords needs-patch added; has-patch removed

This is a regression from 3.0, but the current patch doesn't fix it.

#11 @scribu
10 years ago

Sorry, was caused by me having SCRIPT_DEBUG off (but STYLE_DEBUG on). Different bug.

Patch works, but it goes against #8810.

#12 @scribu
10 years ago

  • Keywords has-patch commit added; needs-patch removed

After further review, I think the current patch is the way to go. It works and it will make the plugins screen consistent with all the rest.

#13 @ryan
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17116]) Remove unnecessary nowraps. Props scribu. fixes #15834

#14 @scribu
10 years ago

Yeah, props should go to ocean90, since it was his patch.

#15 @garyc40
9 years ago

Removing nowrap makes plugins table look bad. See #16536.

Note: See TracTickets for help on using tickets.