WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#15842 closed defect (bug) (fixed)

Plugin install thickbox for importers needs to account for the admin bar

Reported by: nacin Owned by: ocean90
Milestone: 3.1 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch commit dev-reviewed
Focuses: Cc:

Description

Currently doesn't based on testing.

Attachments (1)

15842.patch (1.3 KB) - added by ocean90 5 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 @ocean905 years ago

  • Owner set to ocean90
  • Status changed from new to reviewing

@ocean905 years ago

comment:2 @ocean905 years ago

  • Keywords has-patch added

Patch adds the styles/scripts to import.php. (Also a small RTL fix for the Admin Bar)

comment:3 @nacin5 years ago

Looks fine.

Were we not already enqueuing the plugin-install script on this page? How else does it all work?

comment:4 @ocean905 years ago

It works, because the frame gets his height/width from the URL ...&width=600&height=550 and from the Thickbox function tb_position. 550px works, if the screen is high enough. If it's smaller, then it will be overlapped by the admin bar. The plugin-install script will fix this.

comment:5 @ryan5 years ago

  • Keywords commit added

comment:6 @westi5 years ago

  • Keywords dev-reviewed added

How these never got added I don't know.

comment:7 @nacin5 years ago

Leaving the wp-includes/css/admin-bar-rtl.dev.css change out of the commit. Pretty sure I've seen that in a related patch.

comment:8 @nacin5 years ago

Ah, that diff is already in trunk.

comment:9 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

(In [17086]) Enqueue plugin-install scripts and styles on import.php. props ocean90, fixes #15842.

comment:10 @nacin5 years ago

(In [17087]) Minify plugin-install.js. see #15842.

Note: See TracTickets for help on using tickets.