Search Bug in Network Admin

[pmaiorana]

Steps to reproduce:

1) From /wp-admin/network/ Search Users for a non-existant user; it's important that it's a non-existant user because this bug only happens when no results are returned.

2) You should now be on a User Search results page and see the string "No users found."

3) From that page, search using the box in the top-right for another user that DOES exist.

4) The page will still return "No users found", even though it should return at least one matching user.

In our testing the bug has been fairly consistent, but not 100% reproducible every time. Try multiple attempts and multiple browsers if you don't see it on first pass.

[westi]

This is probably a generic List Table and query string search issue.

We should check them all.

[scribu]

The root cause of the bug is the inconsistency between screens with no items, depending on wether you got there via an ajaxified action or via URL (directly).

[scribu]

Disable ajaxification if there are no items

[scribu]

quick.15849.diff is a quick fix for 3.1.

A better solution would be to always display the table, but with a placeholder row when there are no items.

Working on a patch for that.

[scribu]

Always display the table, with placeholder row

[scribu]

placeholder.15849.diff is the better solution, which turns out isn't too hard to implement.

[scribu]

(In [17002]) Always display the table, with a placeholder row when there are no items. Fixes #15849

[scribu]

(In [17003]) Remove placeholder row when adding first term. See #15849