WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#15866 closed defect (bug) (fixed)

Update notification bubble for net admin

Reported by: PeteMall Owned by: nacin
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Network Admin Keywords: has-patch
Focuses: multisite Cc:
PR Number:

Attachments (3)

15866.diff (3.0 KB) - added by PeteMall 9 years ago.
update-notification.png (230.9 KB) - added by PeteMall 9 years ago.
15866.2.diff (3.9 KB) - added by nacin 9 years ago.
Cap check fixes. Untested.

Download all attachments as: .zip

Change History (13)

@PeteMall
9 years ago

#1 @PeteMall
9 years ago

  • Description modified (diff)

#2 @nacin
9 years ago

(In [17029]) Add theme update bubble, hide redundant bubble on network admin. props PeteMall, see #15866.

#3 @nacin
9 years ago

I was going to remark it looked odd that the update-core.php is install_plugins. But it's the same in wp-admin/menu.php too.

But then we use update_plugins in update-core.php itself. That's a better check I think. Were's the update_core check? Don't we have that cap?

#4 @nacin
9 years ago

  • Owner set to nacin
  • Status changed from new to accepted

#5 @nacin
9 years ago

(In [17040]) Change this string now so we can freeze earlier. see #15866.

@nacin
9 years ago

Cap check fixes. Untested.

#6 @nacin
9 years ago

Patch moves to update_core for update-core.php. Also checks update_plugins for both display and the action, and update_themes for display and the action.

Plugin/theme updates can already take place on those respective pages, so I am not concerned about someone who might have update_plugins and/or update_themes but not update_core from now seeing this page -- at least for 3.1. Again, that'd have to be a plugin anyway. None of our constants split the three update_ caps from each other.

I committed a perfectly generic string that way translators can get going on it.

#7 @nacin
9 years ago

  • Keywords has-patch added

#8 @ryan
9 years ago

Looks good. Reviewed but haven't tested yet.

#9 @nacin
9 years ago

Tested. Denied one, two or three of the caps. Checked both the UI and the post handlers.

#10 @nacin
9 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [17048]) Use the update_core, update_plugins and update_themes caps in update-core.php. fixes #15866.

Note: See TracTickets for help on using tickets.