Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#15891 closed enhancement (wontfix)

TwentyTen: Show navigation <div> when needed

Reported by: zeo Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch 2nd-opinion
Focuses: Cc:


Show navigation <div> only when there's previous/next post (single view), attachment count more than 1 (attachment view).

Attachments (1)

15891.diff (4.0 KB) - added by zeo 8 years ago.

Download all attachments as: .zip

Change History (5)

#1 @nacin
8 years ago

A naked get_adjacent_post() just looks for the previous post.

This seems unnecessary. Many people might style the site using the navigation (for example, clearing, borders, etc.) and very rarely will it ever be empty for both previous/next. Might be good for future default themes, but not now with custom CSS and child themes.

8 years ago

#2 @zeo
8 years ago


I agree it's a rare case. Just sharing. It's your call.

Btw, there's a navigation check in loop.php and comments.php.

Last edited 8 years ago by zeo (previous) (diff)

#3 @nacin
8 years ago

  • Keywords 2nd-opinion added; dev-feedback removed
  • Type changed from defect (bug) to enhancement

Yes, for multiple pages. Not for previous/next.

#4 @nacin
8 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.