WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#15908 closed defect (bug) (fixed)

Reply and Quick Edit form disappears after changing page in comment lists

Reported by: garyc40 Owned by: garyc40
Milestone: 3.1 Priority: normal
Severity: minor Version: 3.1
Component: Comments Keywords: has-patch needs-testing dev-feedback
Focuses: Cc:

Description

Steps to reproduce:

  1. Go to Comments. Click Reply on any comments.
  2. Navigate to another page using the AJAX pagination controls
  3. Try clicking Reply on any comments. The form is not showing.

Same thing happens to Quick Edit form (the comment disappears, and no Quick Edit form is shown).

Working on a fix.

Attachments (4)

garyc40-15908.patch (921 bytes) - added by garyc40 5 years ago.
there's a patch for that
garyc40-15908-rev2.patch (1.2 KB) - added by garyc40 5 years ago.
close all quicktags when commentReply.close()
quickedit-height.png (42.2 KB) - added by garyc40 5 years ago.
Problem with QuickEdit form's height when editing a reaaaally long comment (pay attention to the scrollbar on the right)
garyc40-15908-rev3.patch (1.7 KB) - added by garyc40 5 years ago.
fixed quick edit's height when editing a long comment

Download all attachments as: .zip

Change History (13)

@garyc405 years ago

there's a patch for that

comment:1 @garyc405 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

comment:2 @ocean905 years ago

Confirmed and it's a regression. But quick edit for posts works.

comment:3 @nacin5 years ago

  • Milestone changed from Awaiting Review to 3.1

comment:4 @garyc405 years ago

Quick Edit doesn't work for me. Steps to reproduce:

  • Quick Edit any comment
  • Without updating the comments, change the page by using the pagination controls
  • Try clicking "Quick Edit" on any comment, the comment disappears and no form shows up.

The patch I attached fixes it for both Reply and Quick Edit form.

Last edited 5 years ago by garyc40 (previous) (diff)

comment:5 @ocean905 years ago

  • Component changed from General to Comments

commentReply.close() and/or commentReply.revert() should also reset the quicktags. For example click the button for the bold tag (b) change page and you will see the close bold tag (/b).

@garyc405 years ago

close all quicktags when commentReply.close()

@garyc405 years ago

Problem with QuickEdit form's height when editing a reaaaally long comment (pay attention to the scrollbar on the right)

@garyc405 years ago

fixed quick edit's height when editing a long comment

comment:6 @ocean905 years ago

  • Keywords dev-feedback added

QuickEdit form's height and the quicktags button reset exists both in 3.0.3 too, so not a regression, maybe create a new ticket with 3.2-early keyword.

comment:7 @garyc405 years ago

Got it, please ignore rev2 and rev3, then.

Final patch

comment:8 @ryan5 years ago

garyc40-15908.patch for 3.1. The other patches will be handled in 3.2 on #15911.

comment:9 @ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17089]) Comment reply and quick edit js fixes. Props garyc40. fixes #15908

Note: See TracTickets for help on using tickets.