WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#15909 closed defect (bug) (fixed)

outdated jquery.form.js

Reported by: bmb Owned by: azaozz
Milestone: 3.2 Priority: normal
Severity: minor Version: 3.0.3
Component: External Libraries Keywords: has-patch 3.2-early
Focuses: Cc:

Description

the jquery form plugin version shipped with wp is from about 3 years old. Shouldn't it be updated?

Attachments (4)

jquery.form.dev.js (22.1 KB) - added by duck_ 4 years ago.
15909.diff (49.5 KB) - added by duck_ 4 years ago.
jquery.form.diff (50.3 KB) - added by niallkennedy 3 years ago.
more recent diff from v 2.63 released Jan 29 2011
jquery.form.2.73.diff (50.9 KB) - added by duck_ 3 years ago.
2.73 released 3 May 2011

Download all attachments as: .zip

Change History (10)

comment:1 nacin4 years ago

  • Keywords close added

There's a note in the script-loader: // deprecated, not used in core, most functionality is included in jQuery 1.3.

If it's not deprecated upstream, I don't see much issue updating it for plugins to use it and/or who are using it now, since we probably can't just remove it.

duck_4 years ago

duck_4 years ago

comment:2 duck_4 years ago

  • Keywords has-patch added; close removed

Still being maintained, last commit just a couple of weeks ago.

comment:3 nacin4 years ago

  • Keywords 3.2-early added
  • Milestone changed from Awaiting Review to Future Release

niallkennedy3 years ago

more recent diff from v 2.63 released Jan 29 2011

comment:4 duck_3 years ago

  • Milestone changed from Future Release to 3.2

Closed #17471 as duplicate. Latest version is now 2.73.

duck_3 years ago

2.73 released 3 May 2011

comment:5 azaozz3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [17944]:

Update jQuery Form plugin, props duck_, fixes #15909

comment:6 azaozz3 years ago

  • Type changed from enhancement to defect (bug)

The script jquery.form.js is not deprecated but it's use is deprecated in WordPress core. We used to use it long time ago as it was adding methods similar to .serialize() and serializeArray(). However these methods were added in jQuery 1.3 making the script redundant for core use.

Agree we needed to update it so we don't break plugins that use it but perhaps we can give a warning and remove it early in 3.3.

Note: See TracTickets for help on using tickets.