wp_count_terms() hide_empty not working

[zeo]

For tax category, wp_count_terms( 'category', array( 'hide_empty' => true ) ) returns all category and doesn't hide category with post count 0. Instead need to use wp_count_terms( 'category', array( 'hide_empty' => true, 'hierarchical' => false ) ).

Since hide_empty=false is the default args, wp_count_terms() should set hierarchical=false by default too.

[markjaquith]

Bug reproduced. Patch fixes it.

[scribu]

Is this a regression?

[markjaquith]

This is not a regression from 3.0, so I'm going to do it 3.2-early.

[markjaquith]

patch at a deeper level

[SergeyBiryukov]

Closed #19340 as a duplicate.

[wonderboymusic]

Refreshed against trunk just so the line numbers match - this is from the class of 3.2-early

[faishal]

updated patch

[SergeyBiryukov]

Generally, a refresh is only needed when the patch no longer applies cleanly.

Line numbers may be off, but as long as the content is the same, the patch should still apply cleanly. 15919.002.diff​ is still fine.

Also, when copying code directly from Trac, make sure to remove trailing whitespace.

[wonderboymusic]

these are all marked 3.7-early

[wonderboymusic]

In 25551:

Ensure that terms with a post count of 0 are not returned in wp_count_terms() when hide_empty => true. Adds unit test which ensures that wp_count_terms() returns 0.

Props markjaquith.
Fixes #15919.