WP_MS_Themes_List_Table plural

[scribu]

Currently, the plural is set to 'plugins'. This is a hack to avoid duplicating CSS.

The problem is that the plural is used for generating the nonce too.

The attached patch limits the hack to only the CSS class, allowing the correct nonce to be generated and checked.

[westi]

Can we not just add themes to the CSS file in the relevant places too?

[ocean90]

15922.css1.patch is the first pass.

​(Discussion on IRC)

[scribu]

I hesitated to add the styles, since I think it would be better if we had a single, generic 'themesorplugins' class (with a better name obviously).

[ocean90]

Decision from scribu, JohnONolan and me. Keep the .plugins class and add instead of the .themes class a more generic class name, which we will use for the plugins and themes list. Proposals for a name?

(Sitenote: We need to find a way to deprecate CSS.)

[ryan]

Replying to ocean90:

Decision from scribu, JohnONolan and me. Keep the .plugins class and add instead of the .themes class a more generic class name, which wil will use for the plugins and themes list. Suggestions?

Fine by me.

[ryan]

Per IRC discussion, we're going with the simple, conservative 15922.diff patch and whatever nonce fixes that requires.

[nacin]

I believe 15922.diff fixes the nonces, yes?

[scribu]

The 'bulk-themes' nonce is already set in /network/themes.php but it doesn't seem to be checked anywhere. If it were, there would be some errors, without this patch.

[ryan]

(In [17115]) Set the correct plural. Use plugins class on the table. Props scribu. fixes #15922

[scribu]

As stated above, the nonce check is missing.

[ryan]

(In [17121]) Check bulk-themes nonce before bulk delete. fixes #15922

[ryan]

There are other places that need nonces. We can audit them in a dedicated ticket.