Admin bar on frontend displays Visit Site for current site too

[demetris]

On a multisite setup, on the frontend, the admin bar has a Visit Site menu item for the site you are on (under My Sites › Site Name).

This can be confusing, and it is certainly weird.

[ocean90]

Why confusing? There is also the Manage Comments and New Post menu item.

[demetris]

A visual explanation of the issue

[demetris]

@ocean90: See the screenshot I attached.

[nacin]

A better comparison would be blog->bloguser_id and blog_id. Also ! is_admin.

[demetris]

Maybe, instead of removing the Visit Site item for the current site, we could change the text to Home Page?

Just throwing the idea out; I have not thought it through and I am not an MS user either.

[westi]

I think this might just be a going a bit overboard personally.

Simpler just to keep it as it is IMHO.

[SergeyBiryukov]

Updated the patch (just in case).

[markjaquith]

I'm not too worried about this for 3.1, and it's "punt with prejudice" time.

[ocean90]

'Visit Site' and 'Dashboard' should be clear enough, they're fixed terms. See also r18194.