Add 'media_default_link_type' option to parallel 'image_default_link_type'

[goldenapples]

It is often recommended that site owners change the 'image_default_link_type' option to "none" if they don't plan on linking to full size images often from their posts. The problem is that this also affects the default link type for other media (uploaded zip files, pdfs, etc.) Adding an additional option for 'media_default_link_type' which behaves in the same way would get around this problem.

[goldenapples]

Adds option for media_default_link_type.

[mdawaffe]

Could also put a filter in image_link_input_fields().

[ryno267]

agree. Images shouldn't default link to themselves. or the attachement page.. no need to index that. Images should be default w/ no link.

[nacin]

Rather than adding a new option, we can just drop a filter on that value and ensure that $post gets passed to it.

[goldenapples]

I agree a filter is much better than adding a new option. I would like to see it default to "link to file", though, whatever the image_default_link_type setting is. Would this break much current usage?

I'm trying to brainstorm mainstream cases where people might want to link non-image media to an attachment page, and I can't think of any offhand. Maybe podcasting? I'm not sure. In any case, I think the hassle caused to the everyday site owner who has to remember to check an additional box when inserting pdfs or .zip downloads into post content could be alleviated by treating media and image links separately.

[MadtownLems]

A filter on this sounds great. Would core want to:

a) just add a filter but not change any current functionality without a plugin

or

b) also change some defaults so that images are not links, but other documents are

[desrosj]

This needs some exploration to determine an approach that works in the current state of Core. Is anyone willing to shepherd this?