WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #15926, comment 40


Ignore:
Timestamp:
10/06/2014 07:42:39 PM (7 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15926, comment 40

    initial v1  
    11I've reviewed the previous patches that add the UI for setting the alt attribute, and patching the bundled themes appeared to be the only feasible solution here.
    22
    3 * As [attachment:15926.3.diff] shows, even if we add the UI to the Custom Header screen or the Customizer, it won't work out of the box if the theme does not support it, which would be confusing. We could probably add `alt` as a [http://codex.wordpress.org/Function_Reference/add_theme_support#Custom_Header new argument] for `add_theme_support( 'custom-header' )` though.
     3* As [attachment:15926.3.diff] shows, even if we add the UI to the Custom Header screen or the Customizer, it won't work out of the box if the theme does not support it, which would be confusing. We could probably add `alt` as a [http://codex.wordpress.org/Function_Reference/add_theme_support#Custom_Header new argument] for `add_theme_support( 'custom-header' )` though, and only display the alt text input if the theme declares support for it.
    44* comment:34 suggests that only header images linked to the home page should have a non-empty alt text, and the site title seems to be the best option in that case. Is there a use case for a different alt text?