WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #15928, comment 92


Ignore:
Timestamp:
01/22/2015 02:08:33 AM (10 years ago)
Author:
joemcgill
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #15928, comment 92

    initial v1  
    11Replying to [comment:91 boonebgorges]:
    22
    3 New patch [attachment: 15928.12.patch] adds a third test to make sure we're not forcing urls into an https scheme when the function is called from a different host using SSL (e.g., the case of a site running admin/front over different hosts). I also modified the logic of `test_wp_get_attachment_with_https_off()` and `test_wp_get_attachment_url_with_https_on_diff_host()` to test that the scheme of the url returned matches the scheme coming out of the uploads directory, which isn't necessarily http.
     3New patch [attachment:15928.12.patch] adds a third test to make sure we're not forcing urls into an https scheme when the function is called from a different host using SSL (e.g., the case of a site running admin/front over different hosts). I also modified the logic of `test_wp_get_attachment_with_https_off()` and `test_wp_get_attachment_url_with_https_on_diff_host()` to test that the scheme of the url returned matches the scheme coming out of the uploads directory, which isn't necessarily http.