WordPress.org

Make WordPress Core

Changes between Initial Version and Version 32 of Ticket #15936


Ignore:
Timestamp:
12/23/2018 01:55:40 PM (3 years ago)
Author:
spacedmonkey
Comment:

Sent some time on this and got a patch working at 15936.diff.

Couple of things, worth noting, to use the filter, you have to put it in a sunrise.php file, which limits it's usefulness, but still might be worth it. This patch was extremely hard to test, so would love some eyes on it.

Setting owner to @jeremyfelt as he knows all things MS bootstrap.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15936

    • Property Status changed from new to assigned
    • Property Focuses multisite added
    • Property Severity changed from normal to major
    • Property Cc mitcho@… info@… micahwave added
    • Property Component changed from General to Networks and Sites
    • Property Owner set to jeremyfelt
    • Property Version changed from 3.0.3 to 3.0
    • Property Milestone changed from Awaiting Review to Future Release
    • Property Keywords has-patch dev-feedback 2nd-opinion added
    • Property Type changed from defect (bug) to enhancement
  • Ticket #15936 – Description

    initial v32  
    22It tries to handle the URL as it as if there were a port appended, but then fails to strip it off. Incidentally the error message here: 'Multisite only works without the port number in the URL.' is untrue, since ports are handled (but for only two particular cases, port 80 and 443).
    33
    4 The attached patch, against Wordpress 3.0.3, fixes both these issues, and allows ports other than 80 and 443 to be used with Wordpress, by just stripping off the trailing port rather than special-casing the two well-known ports, and not incorrectly detecting IPv6 literals as URLs with ports in. It also has the advantage of being much more compact.
     4The attached patch, against WordPress 3.0.3, fixes both these issues, and allows ports other than 80 and 443 to be used with Wordpress, by just stripping off the trailing port rather than special-casing the two well-known ports, and not incorrectly detecting IPv6 literals as URLs with ports in. It also has the advantage of being much more compact.
    55
    66It may be worth someone thinking through whether the substitution is strictly correct with reference to the URL standards, but I'm pretty sure that this is an improvement on the current code.