WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Closed 16 years ago

#15944 closed defect (bug) (fixed)

Notice because of non-existent term_id property on post object

Reported by: filosofo Owned by:
Priority: normal Milestone: 3.1
Component: Template Version: 3.1
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

WP shouldn't assume that the queried object is a taxonomy term, when checking to make sure that it's not the same as the parent item of the current menu item.

Attachments (1)

dont-assume-queried-object-is-term.15944.diff​ (650 bytes ) - added by filosofo 16 years ago.

Download all attachments as: .zip

Change History (7)

@filosofo
16 years ago

#1 follow-up: @nacin
16 years ago

Looks sane to fix in 3.1, no?

Also looks like a duplicate of #15935. I'll close that one.

#2 in reply to: ↑ 1 @filosofo
16 years ago

Replying to nacin:

Looks sane to fix in 3.1, no?

I see now that it's a regression from 3.0. I plead the fifth about whose patch introduced it.

#3 @nacin
16 years ago

  • Milestone Future Release → 3.1

:-)

#4 @scribu
16 years ago

Couldn't get_queried_object_id() be used instead?

#5 @filosofo
16 years ago

No, because we don't want an accidental coincidence between a post object ID number and term ID number.

#6 @ryan
16 years ago

  • Resolution → fixed
  • Status new → closed

(In [17109]) Don't assume queried object is a term. Fixes non-existent var notice. Props filosofo. fixes #15944

Note: See TracTickets for help on using tickets.