dbDelta SET Default <literal> Comment <literal>

[hbanken]

When dbDelta from wp_admin/includes/upgrade.php is used with a query containing different DEFAULT values than the actual TABLE in the database, dbDelta tries to update this DEFAULT value by altering the table. The regex that is used to find the new DEFAULT value is incorrect.

Right now, the regex is:

| DEFAULT '(.*)'|i

but this should be:

| DEFAULT '([^']*)'|i

...since, in the case a COMMENT value is set in the new query, the COMMENT value is also surrounded by single quotes ' COMMENT 'literal is added to the new default value.

[hbanken]

The regex should be | DEFAULT '([^']*)'|i
I didn't know about the WikiFormatting of ^.

[dd32]

Seems sane enough to me, We should ensure that it matches the command as best as possible.

[wonderboymusic]

this appears harmless to me

[nacin]

I'm changing this to non-greedy (.*?) as it is more obvious (to me) what is going on.

[nacin]

In 24065:

dbDelta: When parsing out the DEFAULT value, avoid being too greedy. props hbanken, fixes #15948.