WP 3.0.x comments popup on pages returning 404 [including posible solution]

[odosuiadan]

comments-popup does not work on pages (but still working on blog entries) since the 3.0.x upgrade.

i confirm bug and sollution on both: my own theme and on default them after adding comments_popup_link and comments_popup_script functions.

after a long time looking for a solution i found that the new "handle_404" method in class WP (wp-includes/classes.php line 475) is the responsable, substituing this method with an older one from wp 2.x brunch solves the problem.

looks like the new method "think" that there is no content when the index file is called with comments_popup parameter on a page id, so it returns a 404 status, as said the old one solves the problem.

[dd32]

attachment 15949.diff added

This removes the post_type limit of comments_popup being a post, this seems to have caused a knock on effect which removes the need to modify handle_404 and canonical.

It appears that 3.0 has the same problem which this patch fixes, modifying handle_404() may cover the problem in 3.0, but it doesn't in 3.1.

As this isn't a regression from 3.0, and we're in a RC stage, I'm leaving this for 3.2 at this stage.

[wonderboymusic]

I don't see a bug here anymore - @dd32?

[dd32]

@wonderboymusic
What theme did you test with? It's hard to find any themes which still use the popup functions..

[wonderboymusic]

I just used the functions to generate the link inside of 2013

[chriscct7]

Can anyone reproduce this? I've been unable to do so

[wonderboymusic]

Not reproducible plus no meaningful discussion in 5 years