WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Closed 15 years ago

Last modified 15 years ago

#15954 closed enhancement (fixed)

Current Item not applied to root relative links

Reported by: WraithKenny Owned by: nacin
Priority: normal Milestone: 3.3
Component: Menus Version: 3.1
Severity: normal Keywords: has-patch 3.3-early
Cc: Focuses:

Description

The check for the 'current-menu-item' class should test if the $item_url is a site root relative link.

Attachments (2)

root_relative_current.patch​ (999 bytes ) - added by WraithKenny 16 years ago.
Give current-menu-item class even if the link is root relative
root_relative_current.15954.2.diff​ (1.2 KB ) - added by filosofo 16 years ago.

Download all attachments as: .zip

Change History (17)

@WraithKenny
16 years ago

Give current-menu-item class even if the link is root relative

#1 @WraithKenny
16 years ago

  • Owner changed from wraithkenny to WraithKenny
  • Status new → accepted

#2 @scribu
16 years ago

  • Type defect (bug) → enhancement

#3 @ocean90
16 years ago

  • Owner changed from WraithKenny to filosofo
  • Status accepted → assigned

@filosofo
16 years ago

#4 @filosofo
16 years ago

root_relative_current.15954.2.diff is basically WraithKenny's patch but makes use of the untrailingslashit work earlier, to avoid duplication.

Last edited 16 years ago by filosofo (previous) (diff)

#5 @filosofo
16 years ago

  • Keywords 3.2-early added
  • Milestone Awaiting Review → Future Release

#6 @WraithKenny
15 years ago

still good for 3.2 early?

#7 @WraithKenny
15 years ago

tested against 3.3-aortic-dissection still good.

#8 @WraithKenny
15 years ago

  • Keywords 3.3-early added; 3.2-early removed

#10 @jamescollins
15 years ago

Marked #16724 as a duplicate of this.

root_relative_current.15954.2.diff looks good to me. Is there any chance that this can be included in the scope of 3.3?

#11 @nacin
15 years ago

  • Milestone Future Release → 3.3
  • Owner changed from filosofo to nacin
  • Status assigned → accepted

#12 @nacin
15 years ago

  • Resolution → fixed
  • Status accepted → closed

In [18746]:

Detect current menu items for root-relative URLs. props filosofo, fixes #15954.

#14 @WraithKenny
15 years ago

As filosofo said, the patch was basically mine... I wouldn't mention it, but I was hoping to make the credits page. Good enough for props?

#15 @nacin
15 years ago

Sorry about that, WraithKenny.

Note: See TracTickets for help on using tickets.