WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 2 years ago

#15956 closed defect (bug) (wontfix)

Remove user link should be red

Reported by: scribu Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Multisite Keywords:
Focuses: Cc:

Description (last modified by scribu)

On MultiSite, a user has a 'Delete' action link, which erases them from the system completely. It is red.

When going to Network Admin -> Sites -> Edit Site -> Users there is a 'Remove' link, which only erases a user from a certain site in the network. This is currently blue.

Since it's still a destructive action (no trash), the 'Remove' link should be red as well.

Attachments (1)

15956.diff (1.3 KB) - added by greuben 5 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 @scribu5 years ago

  • Description modified (diff)

@greuben5 years ago

comment:2 @solarissmoke4 years ago

  • Keywords has-patch added

comment:3 @scribu3 years ago

  • Component changed from UI to Multisite
  • Description modified (diff)
  • Milestone changed from Future Release to 3.4

Patsh still works.

comment:4 follow-up: @scribu3 years ago

  • Keywords ux-feedback added

Now I'm starting to wonder if this was intentional. It's a destructive operation, but it doesn't delete the user.

Last edited 3 years ago by scribu (previous) (diff)

comment:5 in reply to: ↑ 4 @DrewAPicture3 years ago

Replying to scribu:

It's a destructive operation, but it doesn't delete the user.

From a consistency standpoint, it should only be red if it completely deletes something just as in Menus we have Delete Menu. You're removing access for a user but not deleting the account and that's why it shouldn't be red. My 2¢.

comment:6 @jane3 years ago

  • Keywords ux-feedback removed

Link colors are not consistent in general. Widgets have blue Delete links that turn red on hover, as do Close links (terrible!). We should do a link colors inventory for 3.5 and make them all comply with styleguide. Remove|Cancel in menus doesn't really make sense either. We're overdue for a consistency sweep on button and link text.

comment:7 @ryan3 years ago

  • Milestone changed from 3.4 to Future Release

comment:8 @jeremyfelt2 years ago

  • Keywords has-patch removed
  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

When deleting a user from the network, 'Delete' is red. When removing a user from an individual site, 'Remove' is blue with a change on hover to red. This seems to be consistent, so closing ticket pending link colors inventory.

Note: See TracTickets for help on using tickets.