WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#15960 closed defect (bug) (fixed)

url_is_accessable_via_ssl does SSL discovery for every RSD request.

Reported by: westi Owned by: westi
Milestone: 3.2 Priority: low
Severity: major Version: 3.1
Component: AtomPub Keywords:
Focuses: Cc:

Description

Every request for the RSD file for a WordPress blog does SSL discovery on the AtomPub Service endpoint.

This is a bit of a waste.

We should just respect the is_ssl'ness of the request and have a filter to allow it to be forced to SSL if required.

Attachments (1)

xmlrpc-app-rsd-fix.diff (2.1 KB) - added by westi 7 years ago.
Remove this code.

Download all attachments as: .zip

Change History (5)

#1 @westi
7 years ago

  • We already respect SSL'ness in site_url
  • You can already force SSL by filtering the result of site_url

We should just rip this code out.

Patch incoming.

@westi
7 years ago

Remove this code.

#2 @westi
7 years ago

For reference code was introduced in [6339] for #5298

#3 @westi
7 years ago

  • Keywords 3.2-early removed
  • Milestone changed from Future Release to 3.2
  • Priority changed from normal to low
  • Severity changed from normal to major

#4 @westi
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17642]) Don't do SSL discovery for every RSD request. APP endpoint already respects the SSLness of the site. Fixes #15960.

Note: See TracTickets for help on using tickets.