#15961 closed defect (bug) (fixed)
WP_Comments_List_Table causes get_pending_comments_num to run a lame query
| Reported by: | westi | Owned by: | westi |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.2 |
| Component: | Comments | Version: | 3.1 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description (last modified by )
In WP_Comments_List_Table::prepare_items we call get_comments to get the comments for the current view.
We then loop through the comments to build an array of post_ids.
We then call get_pending_comments_num with this array of ids.
At no point does prepare_items or get_pending_comments_num do any thing to the array to ensure uniqueness.
Therefore we run queries like this:
SELECT comment_post_ID, COUNT(comment_ID) as num_comments FROM wp__comments WHERE comment_post_ID IN ( '627', '627', '1', '5', '1', '20', '40', '30', '20', '10', '10', '627', '627', '627', '627', '627', '627', '627', '627', '627' ) AND comment_approved = '0' GROUP BY comment_post_ID
Attachments (1)
Change History (7)
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Related #17275 (?)