Don't try to add orphaned pages' parents' slugs to the page URL

[filosofo]

If a page becomes orphaned---in other words, if a page points to a parent object that doesn't exist any more---get_page_uri() doesn't sanity check that the parent object actually exists.

Patch does the check without any extra work, by moving stuff around.

[MikeHansenMe]

checks the status of the parent page before adding it to uri

[MikeHansenMe]

This seems to fix the problem in version (3.5-alpha-21751).

Code used to test:
<?php
$uri = get_page_uri(get_the_ID());
echo '<a href="'. $uri .'">The Page</a>';
?>
The output :
<a href="sample-page/thistoo">The Page</a>

My main concern is I was not using permalinks...

[SergeyBiryukov]

Original patch, refreshed

[SergeyBiryukov]

Same as 15963.2.diff, with proper formatting

[chriscct7]

Careful there @MikeHansenMe with those string comparisons ;)

[MikeHansenMe]

looks like 15963.3.alt.diff​ also had that issue.. My bad. Nice catch!

[MikeHansenMe]

15963.5.diff​ adds unit tests and updates the patch to be a bit simpler. Since it was referencing a post object anyway, we can avoid the call to get_post_status.

[wonderboymusic]

In 34001:

In get_page_uri(), do not add parent slugs to orphaned pages.

Adds unit test.

Props filosofo, MikeHansenMe, MikeHansenMe, chriscct7.
Fixes #15963.

[tanner m]

Hey guys! This patch is causing an issue for me as I have programmatically set private posts as parent. Can we add a filter to the output? I've included a patch.

[wonderboymusic]

needs filter docs - up for grabs

[DrewAPicture]

In 35510:

Pages: Introduce the get_page_uri filter, which makes it possible to manipulate a given page's URI before it's returned from the like-named get_page_uri().

Props tanner-m for the initial patch.
Fixes #15963.

[tanner m]

Awesome, thanks @DrewAPicture and @wonderboymusic!

[dd32]

In 36094:

Pages: get_page_uri() should return the URI at which the resource being accessed is available at, this may include non-'publish' status posts.

Reverts [34001] and fixes the original issue in #15963 - avoiding a PHP Notice for when the post doesn't exist.

Props tharsheblows.
See #15963.
Fixes #35084.

[dd32]

In 36105:

Pages: get_page_uri() should return the URI at which the resource being accessed is available at, this may include non-'publish' status posts.

Reverts [34001] and fixes the original issue in #15963 - avoiding a PHP Notice for when the post doesn't exist.

Merges [36094] to the 4.4 branch.
Props tharsheblows.
See #15963.
Fixes #35084.