WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15979 closed defect (bug) (fixed)

submit_button() causing duplicate #submit on taxonomy pages, breaks ajax add

Reported by: dd32 Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

submit_button is being used to generate 2 submit buttons on taxonomy management pages, the result is that Ajax adding of terms is linked to the search submit button, not the form submit button.

Solution is to change one of these to a unique ID, changing the search button ID seems to be the right choice to me.

Attachments (1)

15979.diff (783 bytes) - added by dd32 3 years ago.
s/#submit/#search-submit/ for search submit buttons on listing tables.

Download all attachments as: .zip

Change History (5)

comment:1 nacin3 years ago

We should do a quick sweep of all submit button calls. This isn't the first conflict we've needed to fix.

dd323 years ago

s/#submit/#search-submit/ for search submit buttons on listing tables.

comment:2 dd323 years ago

  • Keywords has-patch added

comment:3 nacin3 years ago

  • Keywords commit added

comment:4 ryan3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17151]) Give search submit buttons a unique ID. Props dd32. fixes #15979

Note: See TracTickets for help on using tickets.