WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 19 months ago

#16009 closed defect (bug)

Define z-index on the new admin bar — at Version 9

Reported by: BlueKachina Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: Toolbar Keywords:
Focuses: Cc:

Description (last modified by jane)

Proposal for z-index to be defined on the new admin bar (so that it will work in harmony with browser toolbar --> Web Develoepr Toolbar's "Display Element Information" Feature)

When the new admin toolbar is showing,
crucial information from the Web Developer Toolbar's
"Display Element Information" balloon becomes hidden.

Specifying a z-index for the admin toolbar seems to resolve this problem.

ie.
I changed line 92 of class-wp-admin-bar.php,
FROM:

<div id="wpadminbar">

TO:

<div id="wpadminbar" style="z-index:1000;">

It seems that the z-index value is somewhat arbitrary to getting these two toolbars to work in harmony... as I've tried values ranging from 0 to 1000, and they all worked.

Change History (10)

@BlueKachina4 years ago

Comparing before and after code modifications

comment:1 follow-up: @nacin4 years ago

We currently have z-index: 99999;. I imagine the toolbar uses a value of 100 or so.

comment:2 in reply to: ↑ 1 @BlueKachina4 years ago

Just did some more testing... it seems that the highest z-index I previously tested is the highest value that works with the Web Developer Toolbar's yellow balloon. I just tried z-index:1001; and the yellow balloon then appears behind the admin toolbar.
:o(

Looks like any value above 1000 renders the admin toolbar incompatible with the web developer toolbar.

How do you suggest we proceed?
How important is it that the z-index be kept at 99999 for the admin toolbar?

comment:3 follow-up: @filosofo4 years ago

According to this, most browsers can handle much larger z-indices (and no maximum is determined by the standard), so it seems like Web Developer Toolbar bears the responsibility to fix this.

comment:4 in reply to: ↑ 3 @BlueKachina4 years ago

Fair enough.
I've sent a message to the developer of it with the request to increase it above 99999, or to provide an option to specify one.

Regards

comment:5 @BlueKachina4 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

comment:6 @nacin4 years ago

Seems like things like the toolkit and other bookmarklets should attempt a highest z-index as possible. Maybe we could tame ours a bit (say, 9999 rather than ten times that), but 1000 is too low.

comment:7 follow-up: @Denis-de-Bernardy4 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Best I'm aware, 99999 isn't valid CSS, or supported by all browsers if it is. If memory serves -9999 to 9999 is the range that works everywhere.

comment:8 in reply to: ↑ 7 @filosofo4 years ago

Replying to Denis-de-Bernardy:

Best I'm aware, 99999 isn't valid CSS, or supported by all browsers if it is. If memory serves -9999 to 9999 is the range that works everywhere.

The CSS 2.1 spec doesn't seem to say what the max is.

For experiments on browsers' handling of them, please see the link in my previous comment.

comment:9 @jane4 years ago

  • Description modified (diff)
  • Summary changed from Proposal for z-index to be defined on the new admin bar (so that it will work in harmony with browser toolbar --> Web Develoepr Toolbar's "Display Element Information" Feature) to Define z-index on the new admin bar
Note: See TracTickets for help on using tickets.