Editing a Network Activated plugin deactivates it

[Otto42]

When you go to edit a plugin using the plugin editor, it comes back up as "(active)", however it will actually be deactivated.

Only spotted this with Network Activated plugins.

3.1 RC1.

[SergeyBiryukov]

Was able to reproduce with a plugin which was activated both for Network and specifically on the current site. is_plugin_active() was returning true, so plugin was not reactivated for Network.

I guess we can check is_plugin_active_for_network() too. Patch included.

Or perhaps deactivate_plugins() should always check active_plugins, even if $network_wide.

[nacin]

is_plugin_active() checks for is_plugin_active_for_network().

Instead, I imagine the check should probably be based on !empty($_GET['networkwide']). If true, check is_plugin_active_for_network. Otherwise, is_plugin_active.

[SergeyBiryukov]

Revised the condition.

BTW, currently when I activate a plugin for Network, it disappears from wp-admin/plugins.php. Not sure how I've managed to get it activated in both places simultaneously.

[ryan]

Seems fine, but let's add some parens to make the order of operations clear.

[nacin]

I imagine you were able to double-activate because it was active on the main site first, then you network activated it. (Network deactivating it will leave it active on the main site, as before.)

[SergeyBiryukov]

Replying to ryan:

Seems fine, but let's add some parens to make the order of operations clear.

Done.

[SergeyBiryukov]

Replying to nacin:

I imagine you were able to double-activate because it was active on the main site first, then you network activated it. (Network deactivating it will leave it active on the main site, as before.)

When I network activate a plugin, it disappears from the list of active plugins on the main site, so I guess this means it is automatically deactivated there (or should be).

[SergeyBiryukov]

Replying to nacin:

(Network deactivating it will leave it active on the main site, as before.)

Missed this comment. It makes sense for me now.

[ryan]

(In [17183]) Don't deactivate a plugin that is both network activated and activated on the main site after editing. Props SergeyBiryukov. fixes #16011