WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 10 months ago

Last modified 10 months ago

#16012 closed defect (bug) (worksforme)

Importer descriptions i18n

Reported by: SergeyBiryukov Owned by: nacin
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: Import Keywords: has-patch
Focuses: Cc:

Description (last modified by SergeyBiryukov)

At first I've tried to create a ticket on http://plugins.trac.wordpress.org/, but none of the importers are present in the Component dropdown. So I've decided to try it here.

As noted by Rasheed Bydousi on WP Polyglots, importer descriptions are displayed in English. The problem is that register_importer() function is called before the language file is loaded.

I've created patches for all the importers. I've also changed init action to admin_init, which seems to have more sense in this case.

Attachments (13)

blogger-importer-i18n-fix.patch (1.0 KB) - added by SergeyBiryukov 7 years ago.
blogware-importer-i18n-fix.patch (940 bytes) - added by SergeyBiryukov 7 years ago.
dotclear-importer-i18n-fix.patch (1022 bytes) - added by SergeyBiryukov 7 years ago.
greymatter-importer-i18n-fix.patch (1006 bytes) - added by SergeyBiryukov 7 years ago.
livejournal-importer-i18n-fix.patch (1.0 KB) - added by SergeyBiryukov 7 years ago.
movabletype-importer-i18n-fix.patch (1.0 KB) - added by SergeyBiryukov 7 years ago.
opml-importer-i18n-fix.patch (1.1 KB) - added by SergeyBiryukov 7 years ago.
rss-importer-i18n-fix.patch (853 bytes) - added by SergeyBiryukov 7 years ago.
stp-importer-i18n-fix.patch (989 bytes) - added by SergeyBiryukov 7 years ago.
textpattern-importer-i18n-fix.patch (1.1 KB) - added by SergeyBiryukov 7 years ago.
utw-importer-i18n-fix.patch (1013 bytes) - added by SergeyBiryukov 7 years ago.
wordpress-importer-i18n-fix.patch (1.2 KB) - added by SergeyBiryukov 7 years ago.
wpcat2tag-importer-i18n-fix.patch (1.1 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (24)

#1 @nacin
7 years ago

  • Milestone changed from Awaiting Review to WordPress.org

#2 @nacin
7 years ago

  • Owner set to nacin
  • Status changed from new to accepted

#3 @SergeyBiryukov
7 years ago

  • Keywords has-patch added

#4 @duck_
7 years ago

Changeset for WordPress Importer.

#5 @SergeyBiryukov
6 years ago

Related: #18200

Other importers also should be updated for proper i18n, to test language packs on them.

#6 @Workshopshed
6 years ago

Sergey, I've put your changes into the version of the blogger-importer I've been working on this week. See http://core.trac.wordpress.org/ticket/14525#comment:20 as I don't have access to that part of SVN.

#7 @Otto42
5 years ago

Relevant blogger importer changes now live in 0.5.

#8 @SergeyBiryukov
5 years ago

  • Description modified (diff)

#9 @chriscct7
2 years ago

  • Keywords i18n removed

#10 follow-up: @swissspidy
10 months ago

  • Milestone WordPress.org deleted
  • Resolution set to worksforme
  • Status changed from accepted to closed

Just tested this on a local install. The importer descriptions are in my chosen locale, not English.

#11 in reply to: ↑ 10 @SergeyBiryukov
10 months ago

Replying to swissspidy:

The importer descriptions are in my chosen locale, not English.

It still doesn't make much sense to call register_importer() on file inclusion instead of admin_init, but #34114 happened in the meantime, so yeah, this works now :)

Note: See TracTickets for help on using tickets.