RTL fixes for comments list

[SergeyBiryukov]

As originally ​reported by Rasheed Bydousi on WP Polyglots:

Snapshot: ​http://img703.imageshack.us/img703/3889/99392434.gif
Location: wp-admin/edit-comments.php

1. “Check for Spam” button position – There is an extra 8px margin on top of the button.
2. “In reply to” should have a right float.
3. “Author” should have a right float.
4. “Un-spammed by” should have a left float.

[garyc40]

there's a patch for that

[garyc40]

The patch I attached corrected problems #1, #2 and #3.

Problem #4 can be fixed in Akismet stylesheet, so it's not included in my patch.

There's also a change I made in WP_Comments_List_Table, where the positions of "In reply to" and "Submitted on" are reversed in the case of RTL. Don't know if it's really necessary, but I ran with it anyways.

[garyc40]

fixed ajax spinner when saving draft

[garyc40]

removed unnecessary styles introduced in previous patches

[ocean90]

Is it a regression?

@garyc40
Tortoise doesn't like your patch. :-(

[garyc40]

Replying to ocean90:

Is it a regression?

@garyc40
Tortoise doesn't like your patch. :-(

I don't think it's a regression, except for sortable table header floating (which is already fixed in [17166]).

Sorry, seems like diff generated by git is not parsed properly in Turtoise :( Works fine in command line though.

[ocean90]

How it looks without the patch (trunk, language: AR): ​http://grab.by/87Sg

#1: Where is the Check for Spam button?

#2: Looks good. Fixed by [17166].

#3: Looks good too. Fixed by [17166].

#4: Un-spammed by seems to be from Askimet.

Can't see a problem here anymore, close?

[SergeyBiryukov]

Replying to ocean90:

Is it a regression?

Points 2 and 3 are a regression from 3.0. Point 1 is not. Not sure about point 4.

[garyc40]

I should probably have created a separate ticket for this, but could you check Posts -> Add New ? The button "Preview" has a little bit of padding to the left.

My rev2.patch fixes this. Needs to add this to wp-admin-rtl.dev.css:

#minor-publishing .ajax-loading { 
        float:right; 
        padding:3px 4px 0 0; 
} 

[SergeyBiryukov]

Replying to ocean90:

#1: Where is the Check for Spam button?

It's from Akismet, but it uses native .button-secondary class. garyc40's patch fixes the margin.

[SergeyBiryukov]

Replying to garyc40:

I should probably have created a separate ticket for this, but could you check Posts -> Add New ? The button "Preview" has a little bit of padding to the left.

Confirmed. This is a regression too.

[ocean90]

16017.patch will fix the regressions #1 and garyc40's one.

#2 and #3 are fixed through [17166].

#4 is for Askimet, SergeyBiryukov will create a ticket for it.

[SergeyBiryukov]

#4: ​http://plugins.trac.wordpress.org/ticket/1261

[markjaquith]

(In [17179]) Fix some RTL CSS issues. props garyc40. props ocean90. fixes #16017