WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#16027 closed defect (bug) (fixed)

Network Settings vs Network Options

Reported by: wpmuguru Owned by: ryan
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: Network Admin Keywords: has-patch
Focuses: multisite Cc:

Description

Sorry for the late l18n change, I just noticed this.

Menu item is Network Settings, screen title is Network Options. Also, $title set at the top was not being echoed to the screen.

Attachments (4)

16027.diff (808 bytes) - added by wpmuguru 3 years ago.
16027.2.diff (800 bytes) - added by wpmuguru 3 years ago.
16027.3.diff (1.1 KB) - added by wpmuguru 3 years ago.
this one reverts the echo $title
16027.4.diff (806 bytes) - added by wpmuguru 3 years ago.
patch for 3.2

Download all attachments as: .zip

Change History (12)

wpmuguru3 years ago

comment:1 wpmuguru3 years ago

Actually, the Network Settings isn't a new string, just a new string in that location. It's already being translated for the menu.

comment:2 nacin3 years ago

No need to echo $title here, that's just convenience. (The main purpose of $title is for the admin header.)

We have three options here:

  • Force a string change with 'Network Settings'
  • Do nothing and punt to 3.2.
  • Move to 'Settings', which is an existing string, and then prepend 'Network' in 3.2.

I can't find the 'Network Settings' string anywhere.

comment:3 wpmuguru3 years ago

Sorry, it's just Setting in the menu.

Let's go with just Settings for the title.

wpmuguru3 years ago

wpmuguru3 years ago

this one reverts the echo $title

comment:4 markjaquith3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17178]) s/Network Options/Settings/. props wpmuguru. Not a string change (already existed). fixes #16027

comment:5 markjaquith3 years ago

  • Milestone changed from 3.1 to Future Release
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 3.2. Ideal string is "Network Settings." Not worth a string change. "Settings" will do for 3.1.

wpmuguru3 years ago

patch for 3.2

comment:6 wpmuguru3 years ago

  • Keywords close added

I think this one has essentially been fixed in the text changes in 3.2.

comment:7 SergeyBiryukov3 years ago

  • Keywords i18n-change close removed
  • Milestone changed from Future Release to 3.3

Since [18026], menu item is "Network Settings" again.

Suggest to commit 16027.4.diff for consistency with Site Admin strings (e.g. General Settings).

comment:8 ryan3 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from reopened to closed

In [18842]:

s/Settings/Network Settings/. Props wpmuguru. fixes #16027

Note: See TracTickets for help on using tickets.