WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #16031, comment 69


Ignore:
Timestamp:
01/19/16 22:33:10 (22 months ago)
Author:
Veraxus
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16031, comment 69

    initial v1  
    11@DrewAPicture I'm ready to take another stab at this for 4.5... but we have a decision to make: do we want to try to clean up the admin screens and move everything (including the hook) into the WP_List_Table class(es) OR do we want to include the hook in each of the admin screens as my previous comprehensive patch did? 
    22 
    3 Those are really the only two possible approaches. Due to the save-redirect process being handled on each of the admin pages (and not in any WP_List_Table class), putting this hook into WP_List_Table, by necessity, means a massive refactoring of each of the admin screens as well as the associated WP_List_Table child classes. 
     3Those are really the only two possible approaches. Due to the save-redirect process being handled on each of the admin screens (and not in any WP_List_Table class), putting this hook into WP_List_Table, by necessity, means a massive refactoring of each of the admin screens as well as the associated WP_List_Table child classes. 
    44 
    55IMO, this should be a 2-release process. The first (targeting 4.5) being to update the comprehensive patch to refactor each of the admin screens, making them more consistent while adding the necessary hook. The second (targeting 4.6) being to further refactor them by moving the list table related functionality into the appropriate classes.