WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#16034 closed defect (bug) (fixed)

Ascending/descending ajax sorting in Network Admin > Sites doesn't work when sorting by Path/Registered

Reported by: leoj3n Owned by:
Milestone: 3.1 Priority: normal
Severity: minor Version: 3.1
Component: Administration Keywords: has-patch needs-testing
Focuses: Cc:

Description

Ascending/descending ajax sorting in Network Admin > Sites doesn't work when sorting by Path/Registered but does work when sorting by Last Updated.

Path/Registered seems to only do ascending sorting, even though the little arrow for the column changes from pointing down to up and up to down when clicked.

Attachments (3)

garyc40-16034.patch (880 bytes) - added by garyc40 4 years ago.
there's a patch for that
garyc40-16034-rev2.patch (724 bytes) - added by garyc40 4 years ago.
reverted to using blog_id instead of registered, use is_subdomain_install()
16034.diff (1.4 KB) - added by ryan 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 @nacin4 years ago

  • Milestone changed from Awaiting Review to 3.1

@garyc404 years ago

there's a patch for that

comment:2 @garyc404 years ago

  • Keywords has-patch needs-testing added; admin sites sorting removed

comment:3 @ryan4 years ago

registered maps to id because there is no index on registered and sorting on it is extremely slow.

comment:4 @ryan4 years ago

Use is_subdomain_install() instead of SUBDOMAIN_INSTALL, although once again the index here is rather incomplete and may not perform.

@garyc404 years ago

reverted to using blog_id instead of registered, use is_subdomain_install()

@ryan4 years ago

comment:5 @ryan4 years ago

Try that. By default we don't want any sort order. Clicking registered will sort by blog_id asc/desc. Clicking domain/path will search by domain/path according to is_domain_install().

comment:6 @garyc404 years ago

Makes sense. Works great :)

comment:7 @ryan4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17180]) Fix registered and path column sorting. Props garyc40. fixes #16034

Note: See TracTickets for help on using tickets.