wp_dropdown_users() omits current user if current user no longer has posting privileges

[markjaquith]

in 3.1, #4458 was regressed. wp_dropdown_users() no longer includes the current author if they lack privileges.

I'm patching.

[aaroncampbell]

I know the WHERE 1=1 doesn't affect the query at all, but is it really annoying to anyone else? Is there any disadvantage to doing something like this instead?

$this->query_where = '';
...
if ( '' != $this->query_where ) {
	$this->query_where = 'WHERE ' . $this->query_where;
}

[ryan]

I think this needs a group by. Seeing duplicates of the include user.

[nacin]

Aaron: If no other WHERE exists, you'll end up with ( ) OR ... when using include. The 1=1 solves that syntax issue.

[aaroncampbell]

nacin: You could put the ( '' != $this->query_where ) check in there if needed.

It's not a huge deal...it just annoys me to see a bunch of WHERE 1=1 in my logs everywhere.

[ryan]

include is an AND in all other get_*() funcs. Maybe we should leave get_users() as is and fix this with a tweak to wp_dropdown_users().

[ryan]

Introduce include_selected flag and add selected user to the end if not returned in the query

[ryan]

A more conservative approach for 3.1.

[ryan]

(In [17198]) Introduce include_selected arg for wp_dropdown_users(). Add current author to dropdown in post_author_meta_box(). fixes #16045